fastlane: Deliver doesn't submit for review even though it said it did.

New Issue Checklist

Updated fastlane to the latest version
I have read the Contribution Guidelines

Issue Description

Deliver says it successfully submitted application for review when it really didn’t. We use encryption in our app as well as advertisement ID. I did not specify a config for these arguments so I imagine that it failed at that point when submitting the application for review. However, in the logs it still shows it was successfully submitted for review. I had to manually login to itunes connect and submit the application.

The deliver should return an error if it is unable to properly submit for review if that option is set to true.

Complete output when running fastlane, including the stack trace and command used

You can use: --capture_output as the last commandline argument to get that collected for you

[16:32:44]: Loading './fastlane/metadata/en-US/description.txt'...
[16:32:44]: Loading './fastlane/metadata/en-US/keywords.txt'...
[16:32:44]: Loading './fastlane/metadata/en-US/release_notes.txt'...
[16:32:44]: Loading './fastlane/metadata/en-US/support_url.txt'...
[16:32:44]: Loading './fastlane/metadata/en-US/marketing_url.txt'...
[16:32:44]: Loading './fastlane/metadata/en-US/name.txt'...
[16:32:44]: Loading './fastlane/metadata/en-US/privacy_url.txt'...
[16:32:44]: Loading './fastlane/metadata/copyright.txt'...
[16:32:44]: Loading './fastlane/metadata/primary_category.txt'...
[16:32:44]: Loading './fastlane/metadata/secondary_category.txt'...
[16:32:44]: Loading './fastlane/metadata/primary_first_sub_category.txt'...
[16:32:44]: Loading './fastlane/metadata/primary_second_sub_category.txt'...
[16:32:44]: Loading './fastlane/metadata/secondary_first_sub_category.txt'...
[16:32:44]: Loading './fastlane/metadata/secondary_second_sub_category.txt'...
[16:32:45]: Activating language en-US...
[16:32:49]: Uploading metadata to iTunes Connect
[16:32:51]: Successfully uploaded set of metadata to iTunes Connect
[16:32:51]: Starting with the upload of screenshots...
[16:32:51]: Successfully uploaded screenshots to iTunes Connect
[16:32:54]: Uploading binary to iTunes Connect
[16:32:59]: Going to upload updated app to iTunes Connect
[16:32:59]: This might take a few minutes. Please don't interrupt the script.
[16:36:19]: iTunes Transporter successfully finished its job
[16:36:19]: --------------------------------------------------------------------
[16:36:19]: Successfully uploaded package to iTunes Connect. It might take a few minutes until it's visible online.
[16:36:19]: --------------------------------------------------------------------
[16:36:19]: Finished the upload to iTunes Connect
[16:36:22]: Selecting the latest build...
[16:36:24]: Waiting iTunes Connect processing for build 2.3.3 (344.87)... this might take a while...
[16:36:56]: Waiting iTunes Connect processing for build 2.3.3 (344.87)... this might take a while...
[16:37:30]: Waiting iTunes Connect processing for build 2.3.3 (344.87)... this might take a while...
[16:38:01]: Waiting iTunes Connect processing for build 2.3.3 (344.87)... this might take a while...
[16:38:32]: Waiting iTunes Connect processing for build 2.3.3 (344.87)... this might take a while...
[16:39:04]: Waiting iTunes Connect processing for build 2.3.3 (344.87)... this might take a while...
[16:39:36]: Waiting iTunes Connect processing for build 2.3.3 (344.87)... this might take a while...
[16:40:09]: Waiting iTunes Connect processing for build 2.3.3 (344.87)... this might take a while...
[16:40:42]: Selecting build 2.3.3 (344.87)...
[16:40:43]: Successfully selected build
[16:40:43]: Submitting the app for review...
[16:40:55]: Successfully submitted the app for review!

Environment

Please run fastlane env and copy the output below. This will help us help you 👍 If you used --capture_output option please remove this block - as it is already included there.

<details><summary>✅ fastlane environment ✅</summary>

### Stack

| Key                 | Value                                                          |
| ------------------- | -------------------------------------------------------------- |
| OS                  | 10.12.3                                                        |
| Ruby                | 2.0.0                                                          |
| Bundler?            | false                                                          |
| Git                 | git version 2.10.1 (Apple Git-78)                              |
| Installation Source | /usr/local/bin/fastlane                                        |
| Host                | Mac OS X 10.12.3 (16D32)                                       |
| Ruby Lib Dir        | /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib |
| OpenSSL Version     | OpenSSL 0.9.8zc 19 Mar 2015                                    |
| Is contained        | false                                                          |
| Is homebrew         | false                                                          |
| Xcode Path          | /Applications/Xcode.app/Contents/Developer/                    |
| Xcode Version       | 8.2.1                                                          |


### System Locale

| Variable | Value       |   |
| -------- | ----------- | - |
| LANG     | en_US.UTF-8 | ✅ |
| LC_ALL   |             |   |
| LANGUAGE |             |   |


### fastlane files:

**No Fastfile found**


**No Appfile found**


### fastlane gems

| Gem      | Version | Update-Status |
| -------- | ------- | ------------- |
| fastlane | 2.17.0  | ✅ Up-To-Date  |


### Loaded fastlane plugins:

**No plugins Loaded**


<details><summary><b>Loaded gems</b></summary>

| Gem                       | Version      |
| ------------------------- | ------------ |
| slack-notifier            | 1.5.1        |
| i18n                      | 0.7.0        |
| json                      | 1.7.7        |
| thread_safe               | 0.3.5        |
| tzinfo                    | 1.2.2        |
| minitest                  | 5.10.1       |
| activesupport             | 4.2.7.1      |
| CFPropertyList            | 2.3.4        |
| claide                    | 1.0.1        |
| colored                   | 1.2          |
| nanaimo                   | 0.2.3        |
| xcodeproj                 | 1.4.2        |
| rouge                     | 1.11.1       |
| xcpretty                  | 0.2.4        |
| terminal-notifier         | 1.7.1        |
| unicode-display_width     | 1.1.3        |
| terminal-table            | 1.7.3        |
| plist                     | 3.2.0        |
| public_suffix             | 2.0.5        |
| addressable               | 2.5.0        |
| multipart-post            | 2.0.0        |
| word_wrap                 | 1.0.0        |
| tty-screen                | 0.5.0        |
| babosa                    | 1.0.2        |
| highline                  | 1.7.8        |
| commander                 | 4.4.3        |
| excon                     | 0.55.0       |
| faraday                   | 0.11.0       |
| unf_ext                   | 0.0.7.2      |
| unf                       | 0.1.4        |
| domain_name               | 0.5.20161129 |
| http-cookie               | 1.0.3        |
| faraday-cookie_jar        | 0.0.6        |
| fastimage                 | 2.0.1        |
| gh_inspector              | 1.0.3        |
| uber                      | 0.0.15       |
| representable             | 2.3.0        |
| retriable                 | 2.1.0        |
| mime-types-data           | 3.2016.0521  |
| mime-types                | 3.1          |
| hurley                    | 0.2          |
| little-plugger            | 1.1.4        |
| multi_json                | 1.12.1       |
| logging                   | 2.1.0        |
| jwt                       | 1.5.6        |
| memoist                   | 0.15.0       |
| os                        | 0.9.6        |
| signet                    | 0.7.3        |
| googleauth                | 0.5.1        |
| httpclient                | 2.8.3        |
| google-api-client         | 0.9.28       |
| mini_magick               | 4.5.1        |
| multi_xml                 | 0.6.0        |
| rubyzip                   | 1.2.1        |
| security                  | 0.1.3        |
| xcpretty-travis-formatter | 0.0.4        |
| dotenv                    | 2.2.0        |
| bundler                   | 1.14.4       |
| faraday_middleware        | 0.11.0.1     |
</details>


*generated on:* **2017-02-15**
</details>

About this issue

Original URL
State: closed
Created 7 years ago
Reactions: 1
Comments: 31

Commits related to this issue

[spaceship] Fix reporting successful submission even it fails due to problems with Ad ID information iTunes Connect still returns a success status code even the submission was failed because of Ad ID... — committed to thii/fastlane by thii 7 years ago
[spaceship] Fix reporting successful submission even it fails due to (#10045) problems with Ad ID information iTunes Connect still returns a success status code even the submission was failed bec... — committed to fastlane/fastlane by thii 7 years ago
Find nested errors messages Responses sometimes come with nest error messages This should fix #8260 — committed to fastlane/fastlane by taquitos 7 years ago
Find nested errors messages (#10586) Responses sometimes come with nest error messages This should fix #8260 — committed to fastlane/fastlane by taquitos 7 years ago

Most upvoted comments

@DMAPro @LucasVanDongen I’m taking a look at this today.

taquitos on Oct 12, 2017

Oh boy. I found the root cause of this. Looks like Apple started returning errors in different places. Working on a fix.

taquitos on Oct 12, 2017

Same for me (fastlane 2.37.0) [17:52:22]: Successfully selected build [17:52:22]: Submitting the app for review… [17:52:33]: Setting ‘add_id_info_serves_ads’ to ‘false’… [17:52:33]: Setting ‘export_compliance_contains_third_party_cryptography’ to ‘false’… [17:52:33]: Setting ‘export_compliance_encryption_updated’ to ‘false’… [17:52:33]: Setting ‘add_id_info_uses_idfa’ to ‘false’… [17:52:33]: Setting ‘content_rights_contains_third_party_content’ to ‘false’… [17:52:35]: Successfully submitted the app for review! Build was selected, but app is still in Prepare for sumbittion status

Wojcik on Jun 12, 2017

I hadn’t tried it in previous version. However, I did submit today and it went through fine. Here is my lane that worked. I only do encryption and ad tracking. I haven’t tried a version yet where the encryption has changed but with these values when I submit when my encryption hasn’t changed works.

lane :deploy_appstore do |values|
  	app_submission_info = {
		add_id_info_uses_idfa: true, 
		add_id_info_tracks_install: true, 
		add_id_info_tracks_action: true, 
		add_id_info_limits_tracking: true,
		export_compliance_encryption_updated: false
	}
    deliver(ipa:"app.ipa", submit_for_review: true, submission_information: app_submission_info)
    slack(message: "Successfully submitted to appstore!", success: true)
  end

IF apple detects you use the advertiser ID (quite a few cocoapods use them) it will require you to fill in the above with true. In our app we do not use advertiser ID, but pods we use, use them for event submission when users do certain actions and such.

Also, you ONLY set export_compliance_encryption_updated to true if your encryption has changed since the last submission.

Also @LucasVanDongen you need to have submit_for_review: true for the auto submit.

jostster on Feb 23, 2017

please try to set the answers via options (submission_information in deliver:

adopt to your settings.

deliver(submission_information: {
      add_id_info_limits_tracking: true,
      add_id_info_serves_ads: true,
      add_id_info_tracks_action: true,
      add_id_info_tracks_install: true,
      add_id_info_uses_idfa: true,
      content_rights_has_rights: true,
      content_rights_contains_third_party_content: true,
      export_compliance_platform: 'ios',
      export_compliance_compliance_required: false,
      export_compliance_encryption_updated: false,
      export_compliance_app_type: nil,
      export_compliance_uses_encryption: false,
      export_compliance_is_exempt: false,
      export_compliance_contains_third_party_cryptography: false,
      export_compliance_contains_proprietary_cryptography: false,
      export_compliance_available_on_french_store: false
    })

also be sure that tester info is set via app_review_information

deliver(app_review_information: {
  first_name: 'Helmut',
  last_name: 'Januschka',
  phone_number: '+43 11111',
  email_address: 'helmut@januschka.com',
  demo_user: 'trottendes.lama',
  demo_password: 'xxxxx',
  notes: 'app should be usable even with no user'
})

hjanuschka on Feb 22, 2017