faker: Remove unavailable LoremPixel generator
LoremPixel is no longer an available service. An option is to use LoremFlickr whenever LoremPixel is referenced in the codebase.
Before we remove it, we need to add a deprecation for users.
Steps
- Add a deprecation warning that LoremPixel is going to be removed in the next release. See
Gem::Deprecatedocs for reference. - Merged in #2590 - Use LoremFlickr whenever LoremPixel was being used, such as here. This will fix the deprecation warnings we see on our specs - Merged in #2614
- Remove deprecated LoremPixel generator. This can only be done after December 2022.
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 25 (22 by maintainers)
Hey folks, would it be okay if I started working on this one?
Yeah, makes sense to delete it since it’s not up anymore: https://github.com/faker-ruby/faker/blob/15a8bc35f489b2d5e06439c664363c779b125d6c/lib/faker/default/lorem_pixel.rb#L61
Hi @stefannibrasil and @uzorjchibuzor, my apologies. It was my first attempt to contribute open source. I will close the PR and try another issue, in case you need it, I can reopen. Thank you very much!!
@stefannibrasil No questions.
Thank you.
@stefannibrasil I am not sure I understand this part, shouldn’t this say that I should add a test on lorem_pixel instead that when is it called to refer to the lorem_flickr?
Also, all of the previous assertions on test_lorem_flickr are not relevant anymore as calls to that class are forwarded to LoremFlickr. What I am asking is that, after I test for the referral, is there anything more to add?
@stefannibrasil I’ll make sure to mention you in the PRs. So this issue can remain open until all the tasks are done.
I’ll pick this up.
we need to delete the class because loremflickr.com is down