wcmatch: wcmatch is missing typehints

While trying to adopt the wmatch I discovered that it does not have type hints. Adding them would really be appreciated as we do want to write better Python code.

# As reported by mypy:
 error: Skipping analyzing 'wcmatch.pathlib': found module but no type hints or library stubs

About this issue

  • Original URL
  • State: closed
  • Created 3 years ago
  • Comments: 23 (21 by maintainers)

Most upvoted comments

I’m flagging this with a “maybe” as the actual value for the project is low is here. People may want type hints in their editors, and I can understand that, but currently, for the project itself, it adds very little actual value.

We’ve documented the API quite well, so there shouldn’t be any big surprises as far as inputs go.

So, this will be flagged as “maybe” with the likeliness increasing if there is assistance.

@gir-bot add P: maybe

I come from a C/C++ background, so I do understand the arguments for type hints and such. While I’ve considered looking into them, they also haven’t been a high priority. I don’t feel that not having them detracts from the usefulness of wcmatch, but I can understand that for those that use IDEs and such, type hinting can be desirable.

@gir-bot remove S: triage @gir-bot add T: enhancement