velox: Window Variance Fuzzer Failure
Description
Error Reproduction
No response
Relevant logs
I0319 04:05:44.611481 6197 AggregationFuzzer.cpp:532] ==============================> Started iteration 6650 (seed: 3070399165)
I0319 04:05:44.618933 6197 AggregationFuzzer.cpp:624] Executing query plan:
-- Window[partition by [p0] order by [s0 ASC NULLS LAST, s1 ASC NULLS LAST, s2 ASC NULLS LAST, s3 ASC NULLS LAST, s4 ASC NULLS LAST] w0 := variance(ROW["c0"]) RANGE between UNBOUNDED PRECEDING and CURRENT ROW] -> c0:INTEGER, p0:BOOLEAN, s0:VARCHAR, s1:SMALLINT, s2:BIGINT, s3:BOOLEAN, s4:BOOLEAN, row_number:BIGINT, w0:DOUBLE
-- Values[1000 rows in 10 vectors] -> c0:INTEGER, p0:BOOLEAN, s0:VARCHAR, s1:SMALLINT, s2:BIGINT, s3:BOOLEAN, s4:BOOLEAN, row_number:BIGINT
I0319 04:05:44.632791 408456 Task.cpp:721] All drivers (1) finished for task test_cursor 164443 after running for 13 ms.
I0319 04:05:44.632814 408456 Task.cpp:1373] Terminating task test_cursor 164443 with state Finished after running for 13 ms.
I0319 04:05:44.634290 6197 AggregationFuzzer.cpp:639] [ROW ROW<c0:INTEGER,p0:BOOLEAN,s0:VARCHAR,s1:SMALLINT,s2:BIGINT,s3:BOOLEAN,s4:BOOLEAN,row_number:BIGINT,w0:DOUBLE>: 1000 elements, no nulls]
../../velox/exec/tests/utils/QueryAssertions.cpp:1046: Failure
Failed
Expected 1000, got 1000
1 extra rows, 1 missing rows
1 of extra rows:
1125385961 | true | "s^B#PDzM(c/npuk,4V<^0>3~`,<@B4HUk}<uQ}.H4Mzc+|k}s9gVDI%~PQ]D[D" | 7829 | 3781926527568724721 | true | true | 528 | 374458249129469700
1 of missing rows:
1125385961 | true | "s^B#PDzM(c/npuk,4V<^0>3~`,<@B4HUk}<uQ}.H4Mzc+|k}s9gVDI%~PQ]D[D" | 7829 | 3781926527568724721 | true | true | 528 | 377387356836932160
Unexpected results
E0319 04:05:44.938828 6197 Exceptions.h:68] Line: ../../velox/exec/tests/AggregationFuzzer.cpp:960, Function:verifyWindow, Expression: assertEqualResults(expectedResult.value(), {resultOrError.result}) Velox and DuckDB results don't match, Source: RUNTIME, ErrorCode: INVALID_STATE
I0319 04:05:44.940961 6197 AggregationFuzzer.cpp:452] Persisted input: /tmp/aggregate_fuzzer_repro/velox_vector_kDCdXD and plan: /tmp/aggregate_fuzzer_repro/velox_plan_ZJJhQb
terminate called after throwing an instance of 'facebook::velox::VeloxRuntimeError'
what(): Exception: VeloxRuntimeError
Error Source: RUNTIME
Error Code: INVALID_STATE
Reason: Velox and DuckDB results don't match
Retriable: False
Expression: assertEqualResults(expectedResult.value(), {resultOrError.result})
Function: verifyWindow
File: ../../velox/exec/tests/AggregationFuzzer.cpp
Line: 960
Stack trace:
# 0 _ZN8facebook5velox7process10StackTraceC1Ei
# 1 _ZN8facebook5velox14VeloxException5State4makeIZNS1_C4EPKcmS5_St17basic_string_viewIcSt11char_traitsIcEES9_S9_S9_bNS1_4TypeES9_EUlRT_E_EESt10shared_ptrIKS2_ESA_SB_
# 2 _ZN8facebook5velox14VeloxExceptionC1EPKcmS3_St17basic_string_viewIcSt11char_traitsIcEES7_S7_S7_bNS1_4TypeES7_
# 3 _ZN8facebook5velox17VeloxRuntimeErrorC2EPKcmS3_St17basic_string_viewIcSt11char_traitsIcEES7_S7_S7_bS7_
# 4 _ZN8facebook5velox6detail14veloxCheckFailINS0_17VeloxRuntimeErrorEPKcEEvRKNS1_18VeloxCheckFailArgsET0_
# 5 _ZN8facebook5velox4exec4test12_GLOBAL__N_117AggregationFuzzer12verifyWindowERKSt6vectorINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESaISB_EESF_SF_RKS5_ISt10shared_ptrINS0_9RowVectorEESaISI_EEb
# 6 _ZN8facebook5velox4exec4test12_GLOBAL__N_117AggregationFuzzer2goEv
# 7 _ZN8facebook5velox4exec4test15aggregateFuzzerESt13unordered_mapINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESt6vectorISt10shared_ptrINS1_26AggregateFunctionSignatureEESaISD_EESt4hashIS9_ESt8equal_toIS9_ESaISt4pairIKS9_SF_EEEmRKS3_IS9_S9_SH_SJ_SaISK_ISL_S9_EEE
# 8 _ZN23AggregationFuzzerRunner3runERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEmRKSt13unordered_setIS5_St4hashIS5_ESt8equal_toIS5_ESaIS5_EERKSt13unordered_mapIS5_S5_SA_SC_SaISt4pairIS6_S5_EEE
# 9 main
# 10 __libc_start_main
# 11 _start
About this issue
- Original URL
- State: open
- Created a year ago
- Comments: 17 (14 by maintainers)
Commits related to this issue
- Disable checking window aggregations results with duckdb results. Summary: DuckDB has a bug in its window aggregations results. https://github.com/facebookincubator/velox/pull/5082 We keep seeing fa... — committed to laithsakka/velox by laithsakka a year ago
- Disable checking window aggregations results with duckdb results. (#5750) Summary: Pull Request resolved: https://github.com/facebookincubator/velox/pull/5750 DuckDB has a bug in its window aggregat... — committed to laithsakka/velox by laithsakka a year ago
- Disable checking window aggregations results with duckdb results. (#5750) Summary: Pull Request resolved: https://github.com/facebookincubator/velox/pull/5750 DuckDB has a bug in its window aggregat... — committed to facebookincubator/velox by laithsakka a year ago
I can consistently reproduce it locally. I will debug.