relay: [Modern] relay-compiler errors on mutation

I’ve cloned this repo https://github.com/apollographql/relay-modern-hello-world by @stubailo and everytime i run yarn run relay i got this message

Writing default
Error writing modules:
TypeError: type.getFields is not a function
Unchanged: 3 files
Written default in 0.29s
✨  Done in 1.72s.

which i don’t know what TypeError: type.getFields is not a function means, i got three other queries and they compile perfectly but i can’t get it to work with mutation. I’m not sure if i’m doing something wrong, any help would be greatly appreciated.

This are my files

//src/mutations/CreateCuisineMutation.js
import { commitMutation, graphql } from "react-relay";

const mutation = graphql`
mutation CreateCuisineMutation($name: String!) {
  createCuisine(name: $name) {
    id
    name
  }
}
`;

function commit(enviroment, name) {
  return commitMutation(enviroment, {
    mutation,
    variables: { name },
    onCompleted: response => {
      console.log("Success!");
    },
    onError: err => console.error(err)
  });
}

export default { commit };

This is my schema for cuisine mutations

type Mutation {
  createCuisine(name: String!): Cuisine
}

type Cuisine {
  id: ID!
  name: String!
  created: String
  updated: String
}

About this issue

Original URL
State: closed
Created 7 years ago
Comments: 17 (13 by maintainers)

Most upvoted comments

finding something similar when theres no $input value used example (working in graphiQL)

mutation IncrementCountMutation {
  incrementCount {
    count
  }
}

compiler returns undefined

Writing default Error writing modules: TypeError: Cannot read property ‘type’ of undefined

andyfen on Apr 21, 2017

It seems that relay-compiler is trying to get each argument from the ast and get it’s fields, given that i get TypeError: type.getFields is not a function and my String in mutation CreateCuisineMutation($name: String!) has no fields

lpalmes on Apr 21, 2017

Yeah, I think this is just a bug as @mjmahone mentioned. Do you have the full stack trace of the error?

Note that Relay Modern relaxes all the restrictions from Relay classic for mutations:

Arbitrary root fields/arguments are supported (can be more than one argument of any name(s), doesn’t have to be an input object)
No need for a clientMutationId field

Please file bugs / send PRs if this isn’t working! Stack trace would help in this case.

josephsavona on Apr 21, 2017

Closing in favor of the 2 linked issues.

kassens on Sep 11, 2017

Hey @henryqdineen, sorry for the delay, it seems that the compiler only works with input type objects, so String!, Int!, etc will not work for now

lpalmes on May 21, 2017

My guess is that mutations have to follow the GraphQL Relay spec in that regard and this is still a requirement with Modern:

https://facebook.github.io/relay/docs/graphql-mutations.html

Great article on designing mutations which happen to align with the relay spec and give you some perspective as to why it’s a good idea: https://dev-blog.apollodata.com/designing-graphql-mutations-e09de826ed97

tlvenn on Apr 21, 2017