react-native: Starting from 0.64.0 `RefreshControl` causes an unwanted visual jump in the list content when the `refreshing` prop goes from `true` to `false`
Description
Starting from 0.64.0
in iOS on a physical device: When using <RefreshControl>
inside <ScrollView>
or <FlatList>
, the content in the list has an unwanted visual jump down when the refreshing
prop goes from true
to false
- this is not the case in 0.63.4
.
https://user-images.githubusercontent.com/1485576/116700722-626f9d00-a9c7-11eb-8ce9-107bf3dca592.mov
React Native version:
System:
OS: macOS 11.2
CPU: (8) x64 Apple M1
Memory: 667.83 MB / 16.00 GB
Shell: 5.8 - /bin/zsh
Binaries:
Node: 14.15.4 - /usr/local/bin/node
Yarn: 1.22.10 - /usr/local/bin/yarn
npm: 6.14.10 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
Managers:
CocoaPods: 1.10.1 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: iOS 14.4, DriverKit 20.2, macOS 11.1, tvOS 14.3, watchOS 7.2
Android SDK:
API Levels: 28, 29, 30
Build Tools: 28.0.3, 29.0.2, 30.0.3
System Images: android-29 | Google Play Intel x86 Atom, android-30 | Google APIs Intel x86 Atom
Android NDK: Not Found
IDEs:
Android Studio: 4.1 AI-201.8743.12.41.7042882
Xcode: 12.4/12D4e - /usr/bin/xcodebuild
Languages:
Java: 1.8.0_282 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 17.0.1 => 17.0.1
react-native: 0.64.0 => 0.64.0
react-native-macos: Not Found
npmGlobalPackages:
*react-native*: Not Found
Steps To Reproduce
Install a clean version of 0.64.0
and run the code from the RefreshControl
docs https://reactnative.dev/docs/refreshcontrol on a physical device. In the provided videos I have only changed the fake timeout from 2000ms
-> 500ms
to show the jumping quicker and printed the refreshing
state.
Expected Results
This is how it looks in 0.63.4
, where no jumping is happening:
https://user-images.githubusercontent.com/1485576/116701050-c1351680-a9c7-11eb-8507-cbc0e8eab36b.mov
Snack, code example, screenshot, or link to a repository:
import React from 'react';
import { RefreshControl, SafeAreaView, ScrollView, StyleSheet, Text } from 'react-native';
const wait = (timeout) => {
return new Promise(resolve => setTimeout(resolve, timeout));
}
const App = () => {
const [refreshing, setRefreshing] = React.useState(false);
const onRefresh = React.useCallback(() => {
setRefreshing(true);
wait(500).then(() => setRefreshing(false));
}, []);
return (
<SafeAreaView style={styles.container}>
<ScrollView
contentContainerStyle={styles.scrollView}
refreshControl={
<RefreshControl
refreshing={refreshing}
onRefresh={onRefresh}
/>
}
>
<Text>{refreshing ? 'Refreshing' : 'Done'}</Text>
</ScrollView>
</SafeAreaView>
);
}
const styles = StyleSheet.create({
container: {
flex: 1,
},
scrollView: {
flex: 1,
backgroundColor: 'pink',
alignItems: 'center',
justifyContent: 'center',
},
});
export default App;
About this issue
- Original URL
- State: open
- Created 3 years ago
- Reactions: 25
- Comments: 24 (4 by maintainers)
Hi Everyone,
This issue still persists on 0.69.5. I am surprised the issue is still there even after more than a year.
Does anyone have a patch for it, until it gets resolved in latest RC
@dandre-hound @mdaj06 @yogevbd @krismeld
Can confirm we’re facing this issue after upgrading RN to 0.64.
I’ve just upgrade to 0.70.5 and I am experiencing this issue.
Thanks everyone for the discussion & investigation. It would be nice to find a fix that resolves both the large navigation use case and general usages here. cc @yogevbd
Hello guys,
We have a reproduction on empty RN template for this issue and video recordings in this issue: https://github.com/facebook/react-native/issues/34394
Steps to reproduce Pull to refresh During refreshing, swipe left (right) on refresh control area
Snack, code example, screenshot, or link to a repository link to a repository: https://github.com/wanted-o/RefreshIssue
https://user-images.githubusercontent.com/14195600/184646719-8972aef1-a622-492e-8ce0-5a8f3deac763.mov https://user-images.githubusercontent.com/14195600/184646770-c538de03-987f-405d-abc2-3e5861c99e6c.mov
I opened (and have now closed) a duplicate issue. I had added some notes there that may be worthwhile to pin to this issue. My notes are in that issue #31563.
just a quick update, aside from the workaround @LukaBabunadze offered, I was able to (STILL) repro the issue using @oleksandr-dziuban’s comment -> https://github.com/facebook/react-native/issues/31461#issuecomment-1217689522
on 0.73.1:
Guys, just add
flex: 1
to the parent and it should work. For example:<View style={{flex: 1}}> <FlatList/> </View>
0.71.8 still have this issue
Yea for sure! No need to ask for permission – I realize some issues I had created (as part of a project effort re: accessibility) I had wanted to coordinate to avoid folks to step on each other’s toes – but other issues in this repo, please grab as interested! Thanks so much for your help!
Would love to see this fixed 🙏🏾