react-native: Some NPM packages don't work
I’ve come across a few npm modules that don’t appear to work correctly. Notably, event-emitter has issues importing es5-ext/object/assign, and debug doesn’t appear to work with the chrome dev-tools. I suspect that small alterations to the module themselves (to take into account yet another working environment) may be necessary, but there could also be issues with the packager, too.
About this issue
- Original URL
- State: closed
- Created 9 years ago
- Reactions: 1
- Comments: 16 (11 by maintainers)
Commits related to this issue
- Do not expose define references in require polyfill Summary: See #406 Made sure the jest tests pass but didn't know a good unit test to add for this. Closes https://github.com/facebook/react-native/... — committed to vjeux/react-native by jgable 9 years ago
- Do not expose define references in require polyfill Summary: See #406 Made sure the jest tests pass but didn't know a good unit test to add for this. Closes https://github.com/facebook/react-native/... — committed to vjeux/react-native by jgable 9 years ago
- Do not expose define references in require polyfill Summary: See #406 Made sure the jest tests pass but didn't know a good unit test to add for this. Closes https://github.com/facebook/react-native/... — committed to vjeux/react-native by jgable 9 years ago
@broonage: we’re building a new js environment (others are browser, web worker, node) and need to figure out what we support. We want to support as few things as possible so that it is easier to maintain and has less bugs overall. It turns out that the community pretty much settled on commonjs and not AMD so this is what we chose to implement. Having two things to do the same thing is usually not a great idea.
If in the future AMD makes a big comeback and there are big incentives to implement it, we could. But trying to keep it as simple as possible for now 😃