react-native: [RN 0.52] RCTImageLoader requires main queue setup since it overrides `init` but doesn't implement `requiresMainQueueSetup`

Is this a bug report?

Yes

Have you read the Contributing Guidelines?

Yes

Environment

Environment:
  OS: macOS Sierra 10.12.6
  Node: 9.3.0
  Yarn: 1.3.2
  npm: 5.6.0
  Watchman: 4.9.0
  Xcode: Xcode 9.2 Build version 9C40b
  Android Studio: Not Found

Packages: (wanted => installed)
  react: 16.2.0 => 16.2.0
  react-native: 0.52.0 => 0.52.0

Steps to Reproduce

$ react-native run-ios

Expected Behavior

iOS simulator run without errors.

Actual Behavior

screenshot 2018-01-09 14 53 14 screenshot 2018-01-09 15 02 18

^

Module RCTImageLoader requires main queue setup since it overrides `init` but doesn't implement `requiresMainQueueSetup`. In a future release React Native will default to initializing all native modules on a background thread unless explicitly opted-out of.

Reproducible Demo

Any app using the Image component, although in my app I wrap that in a higher level component I use: react-native-fit-image.

I’ve never seen RCTImageLoader complain about requiresMainQueueSetup before. Only started now after I upgraded RN from 0.51 to 0.52.

About this issue

  • Original URL
  • State: closed
  • Created 6 years ago
  • Reactions: 34
  • Comments: 19 (6 by maintainers)

Most upvoted comments

can we merge this soon ?

For me, it doesn’t show any warning in the simulator but appears as a warning in the browser console.

RN Version: 0.53.3 React Version: 16.2.0

The warning is still showing in 0.55.2

It’s merged into master but it’s not released in a version as yet

still showing up in 0.55.4 image

Still showing up in 0.55.2

because the warning has no "warning: " prefix. Take that out in your ignore