react-native: On iOS, orientation changes don't animate in a way that "looks native"
Is this a bug report?
Yes
Have you read the Contributing Guidelines?
Yes
Environment
Environment: OS: macOS Sierra 10.12.6 Node: 8.4.0 Yarn: 1.0.1 npm: 5.4.1 Watchman: 4.5.0 Xcode: Xcode 8.3.3 Build version 8E3004b Android Studio: 2.3 AI-162.3934792
Packages: (wanted => installed) react: 16.0.0-alpha.12 => 16.0.0-alpha.12 react-native: 0.48.3 => 0.48.3
Steps to Reproduce
- Create a react native app w/ react native init
- Run it on an iOS device or the iOS simulator
- (If on a simulator) Turn on slow animations (CMD+T) so the issue will be more obvious.
- Rotate the device a few times to landscape and portrait
- Observe that immediately after the orientation changes, the view is resized to the dimensions of the new orientation, and THEN the rotation animation begins. The view’s contents and dimensions are not smoothly resized while the view is being rotated.
Expected Behavior
In a regular native iOS app, when the orientation of the device changes, the view’s contents and dimensions smoothly resize while the view is also rotated at the same time.
Here is a animated gif. This is a simple native app written in swift, see how the view resizes and rotates smoothly (at the same time) on orientation changes:
Actual Behavior
On orientation changes, the view’s dimensions and contents are resized once at the very beginning of the change, and then the rotation animation happens.
Here is another animated git. This is a simple RN app, with a red border applied to the view so you can see how the view’s dimensions are immediately changed (not smoothly animated).
Reproducible Demo
Sadly I can’t seem to get the expo app to handle rotations so I guess having a Snack wouldn’t be useful.
But you can see if yourself pretty easily if you:
- Use
react-native initto create a new app - Edit
index.ios.jsand add to the container’s styles (line ~40):
borderColor: 'red',
borderWidth: 10,
- Then run it, turn on slow animations in the simulator (CMD+T), and change the orientation a few times.
About this issue
- Original URL
- State: open
- Created 7 years ago
- Reactions: 33
- Comments: 29 (3 by maintainers)
Commits related to this issue
- Fix Orientation Change Issue In HelloWord Template This commit is related to issue #16060 Tested through the iOS simulator. Solution came from https://moduscreate.com/blog/changing-the-react-native-... — committed to petekeller2/react-native by petekeller2 6 years ago
- Fix orientation change issue in HelloWord template (#20945) Summary: This commit is related to issue #16060 Tested through the iOS simulator. Solution came from https://moduscreate.com/blog/changing-... — committed to rdonnelly/react-native by petekeller2 6 years ago
- Fix orientation change issue in HelloWord template (#20945) Summary: This commit is related to issue #16060 Tested through the iOS simulator. Solution came from https://moduscreate.com/blog/changing-... — committed to gengjiawen/react-native by petekeller2 6 years ago
- Fix orientation change issue in HelloWord template (#20945) Summary: This commit is related to issue #16060 Tested through the iOS simulator. Solution came from https://moduscreate.com/blog/changing-... — committed to microsoft/react-native-macos by petekeller2 6 years ago
This issue is becoming a blocker for us for using react-native. Also applies to Android. I would love to see it fixed, and can help if necessary.
Is this going to be solved. I am making a video player app and I like to open the player in landscape mode. And when I force the app to show in landcape. The animation is horrible.
Thanks
The amount of jank present in RN is starting to become overwhelming.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions.
same issue here, building an app with a video player with custom controls. It takes a lot of effort and various optimizations to make landscape rotation look not even good but just acceptable. The biggest problem imo is the performance impact caused by all layout recalculations (there multiple per rotation, when dimensions change, and when safe area insets change one by one), causing an already janky animation to look very glitchy and jumpy. Screens with FlatLists are the worst offenders. We’ve been able to eliminate most of the jank with hacky workarounds, but it’s still not perfect. This really ruins the “native” feeling of the app, making it seem amateurish, and puts a big dent into consideration of using React Native for future projects. I myself have already put around a few weeks of time into prettying up this mess, writing so much scaffolding code that it would be enough to build an eiffel tower
Android is affected by it too, but since its rotation animation is not seamless, it’s not as noticable.
+1 is someone fix this issue?
that’s not possible with react-native (i wish it was, e.g. youtube app works like that). The whole app rotates, but because of fixed width and height staying the same, it won’t trigger expensive layout recalculation
+1
@aarondail The gist is that Apple’s CoreAnimation can tween automatically and perhaps iOS uses that during rotations. Someone who worked at Apple or has debugged this in Instruments might be better suited to answer that though. There are a lot of specifics that involve CoreAnimation and UIKit (many of which I’m unfamiliar with) and tbh a lot of the people I’ve met/talked to who know this stuff in and out have spent years with it or were part of the teams who built it. It isn’t necessary to have all of that knowledge to fix this issue (I certainly don’t have it) but I suspect it’s hard to identify which path to take with almost no iOS experience.
Some resources:
Can someone confirm whether this is missing functionality or just a bug?