react-native: java.lang.NullPointerException: Attempt to invoke virtual method 'void com.facebook.react.uimanager.ReactShadowNode.setStyleWidth(float)' on a null object reference

Still happening on my side, without using any Modal (I am using react native navigation and its built-in Modal).

platform: Android (min api 21) react-native: 0.48.3

Not yet. This issue is the most popular 15th issue according to comments and still there is not any comment from the dev team since the beginning of this issue. This issue really caused tremendous frustration on my side.

Yeah, I’ll include it in next RC tomorrow.

Fix is in master now: https://github.com/facebook/react-native/commit/5873a228f41bca763c35c470375a9f3cb36f80ab

Looks like the commit didn’t end up in 0.43 release by a mistake. I have released a new version (0.43.3) along with some other smaller tweaks.

On Mon, 10 Apr 2017 at 07:16 tianxind notifications@github.com wrote:

So this commit is not in RN 0.43?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/facebook/react-native/issues/10845#issuecomment-292851648, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWcxkgG5jsmLZWEWvcEXF3xrKMfBofzks5rubsTgaJpZM4KuSyA .

Sorry for the lack of update, I was able to use the verify what was going wrong, I should have a fix landed to master in the next day or two.

Any updates?

@astreet Hey, I can consistently reproduce this with https://github.com/Cooke/ReactNativeAndroidModalCrashBug/

Hey everyone, sorry you’ve been having these crashes. Without being able to look at a repro, this looks like a race condition between the UI thread and the native modules (background) thread.

onSizeChanged here is enqueueing a runnable from the ui thread that references a shadow view by id on the native modules thread. Since the shadow thread ‘runs ahead’ of the UI thread (e.g. it has a newer state of the world than the UI thread), this isn’t safe. By the time that code block runs, it’s possible that an update from JS has already removed that view from the shadow hierarchy (a change which would then propagate to the native hierarchy on the UI thread). I’m not sure off hand what is causing onSizeChanged to be called, so it could also be something else though – e.g. the View in the hierarchy could not have an id set on it for some reason.

I’ll try to see if I can get someone to look into it given the number of people affected.

I have manged to reproduce my version of this issue consistently and implemented a work-around (not battle-tested): https://github.com/Cooke/ReactNativeAndroidModalCrashBug/blob/master/index.android.js

+1 with version 0.40

@akzhou I solved this by using the InteractionManager runAfterInteractions in a ComponentDidMount, see below for further details:

https://github.com/brentvatne/run-after-interactions-exp/blob/master/index.js

Yeah this bug is pretty nasty, i’ve got 2 bad reviews in play store because of it … I’ve used this fix

const CustomModal = ({ visible = false, children }) => {
  if (!visible) {
    return <View/>
  }
  return (
    <Modal
      style={styles.modalWrapper}
      animationType='slide'
      onRequestClose={() => {}}
      visible={true}
      transparent >
      {children}
    </Modal>
  )
}

Nothing fancy, but works okay

I am having the same issue. I have modal (fullscreen) and android keyboard on. It happens when I close it with enter key (onSubmitEditing). I’ve tried to close modal in InteractionManager.runAfterInteractions callback, but it didn’t help. However It seems to be working when I postpone it with setTimeout(..., 300)

@grabbou This should be pretty safe to merge, what release can we get this into do you think?

I also have the same issue. I just added a delay of 1 sec before swaping to the view which solved this temporarily and there is no crash . This error is not encountered in debug mode, when we generate apk this error message pops up randomly. I believe it is due to react-native-router-flux

+1 for 0.41.2

Experiencing this randomly on startup as well. 0.4.0

I have the same question on React Native Version: 0.39.0 Platform: Android

I am experiencing the same issue. The only way I found to avoid the crash is wrapping the next action in a setTimeout(..., 1000) to give time to the modal to be dismissed.

Maybe we should move this over to Canny, to gain visibility? https://react-native.canny.io/feature-requests

That’ll help the React team understand how many people are affected.

Of course, a consistent repro would go a long way towards us being able to figure out the right fix 😃

Note for anybody reading we solved our problem but in our case it had nothing to do with the Modal.

It was a problem with how we were using react-native-router-flux. We were not managing the scene stack properly. Using Actions.pop() correctly fixed our problem.

I have faced same issue and was able to get around.

I use a boolean to determine visibility of a modal (loading modal in my case). When this boolean value changes value quickly from false to true (modal visible) and true to false (modal invisible), this was causing the crash (probably it was not able to re-render quickly). So I gave a delay of 0.5 seconds before closing the modal and it worked.

Also, when you are debugging, you would not be able to reproduce this issue. As debugging gives enough time, crash wont be seen.

As this use case was taking too small time, there was no need to show loading modal in my case. So I just removed it.