react-native: Changing the bundle ID breaks the upgrader
I’ve changed the bundle ID of my app to the usual com.something.somethingelse
format but because of that react-native-git-upgrade
fails. It writes a bunch of files to paths defined using the name
in package.json
, fails, then resets all the changes.
Is there any way to tell the upgrader what the bundle ID of the apps is supposed to be?
Another problem is that the thing that is supposed to show what part of the upgrade process is broken is apparently broken.
git-upgrade info Commit new version template
git-upgrade info Generate the patch between the 2 versions
git-upgrade info Save the patch in temp directory
git-upgrade info Reset the 2 temporary commits
git-upgrade info Apply the patch
fatal: unrecognized input
git-upgrade WARN The upgrade process succeeded but there might be conflicts to be resolved. See above for the list of files that have merge conflicts.
git-upgrade info Upgrade done
^^^ Unfortunately, there is no list of files
which I’m guessing has something to do with the fatal unrecognized input.
About this issue
- Original URL
- State: closed
- Created 8 years ago
- Reactions: 24
- Comments: 18 (5 by maintainers)
Commits related to this issue
- Forcing git diff to not use colorized output Summary: If a user sets `color.ui` or `color.diff` to `always` in their git configuration files, the output of `git diff` will contain some "color charact... — committed to facebook/react-native by deleted user 7 years ago
- Forcing git diff to not use colorized output Summary: If a user sets `color.ui` or `color.diff` to `always` in their git configuration files, the output of `git diff` will contain some "color charact... — committed to edmofro/react-native by deleted user 7 years ago
- Forcing git diff to not use colorized output Summary: If a user sets `color.ui` or `color.diff` to `always` in their git configuration files, the output of `git diff` will contain some "color charact... — committed to nicktate/react-native by deleted user 7 years ago
- Forcing git diff to not use colorized output Summary: If a user sets `color.ui` or `color.diff` to `always` in their git configuration files, the output of `git diff` will contain some "color charact... — committed to nicktate/react-native by deleted user 7 years ago
- Forcing git diff to not use colorized output Summary: If a user sets `color.ui` or `color.diff` to `always` in their git configuration files, the output of `git diff` will contain some "color charact... — committed to nicktate/react-native by deleted user 7 years ago
- Forcing git diff to not use colorized output Summary: If a user sets `color.ui` or `color.diff` to `always` in their git configuration files, the output of `git diff` will contain some "color charact... — committed to nicktate/react-native by deleted user 7 years ago
- Forcing git diff to not use colorized output Summary: If a user sets `color.ui` or `color.diff` to `always` in their git configuration files, the output of `git diff` will contain some "color charact... — committed to nicktate/react-native by deleted user 7 years ago
- Forcing git diff to not use colorized output Summary: If a user sets `color.ui` or `color.diff` to `always` in their git configuration files, the output of `git diff` will contain some "color charact... — committed to nicktate/react-native by deleted user 7 years ago
- Forcing git diff to not use colorized output Summary: If a user sets `color.ui` or `color.diff` to `always` in their git configuration files, the output of `git diff` will contain some "color charact... — committed to nicktate/react-native by deleted user 7 years ago
- Forcing git diff to not use colorized output Summary: If a user sets `color.ui` or `color.diff` to `always` in their git configuration files, the output of `git diff` will contain some "color charact... — committed to nicktate/react-native by deleted user 7 years ago
- Forcing git diff to not use colorized output Summary: If a user sets `color.ui` or `color.diff` to `always` in their git configuration files, the output of `git diff` will contain some "color charact... — committed to nicktate/react-native by deleted user 7 years ago
- Forcing git diff to not use colorized output Summary: If a user sets `color.ui` or `color.diff` to `always` in their git configuration files, the output of `git diff` will contain some "color charact... — committed to nicktate/react-native by deleted user 7 years ago
- Forcing git diff to not use colorized output Summary: If a user sets `color.ui` or `color.diff` to `always` in their git configuration files, the output of `git diff` will contain some "color charact... — committed to GaborWnuk/react-native by deleted user 7 years ago
- Forcing git diff to not use colorized output Summary: If a user sets `color.ui` or `color.diff` to `always` in their git configuration files, the output of `git diff` will contain some "color charact... — committed to fullcontact/react-native by deleted user 7 years ago
Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we’re automatically closing issues after a period of inactivity. Please do not take it personally!
If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:
If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.
Got the same issue to upgrading from 0.39.2 to 0.40.0
I got the same problem, this worked for me:
Edit
~/.gitconfig
and changeto
I figured this out by manually trying to git apply the patch-file in the folder printed at the end of
react-native-git-upgrade --verbose
(you have to use--verbose
for this folder to be printed). This patch-file was color-coded because I hadui = always
, and this was the reason git printedfatal: unrecognized input
.Getting the same error:
~and it resets to the project snapshot~ it updates and has some files in conflict which I can resolve. Thing is, we have changed a lot of stuff in platform specific project files so I can understand updating RN would be difficult for a tool which checks for manual changes and doesn’t want to overwrite them… (for example: we’ve created new folders for the iOS xcode project which uses a new name… not sure if it updated in that folder. I will check when I have more time at hand)
@vinceprofeta I have delete the android and iOS folder. I run
react-native init
andreact-native link
to recreate these folder. It fix the issue for me 😄I run 0.2.7 and got the same error:
I found what was the issue for me. I had updated and installed the new react package I was looking for. I started again from scratch (just making sure that I was using
"react-native-git-upgrade": "0.2.7"
) and it worked nicely.Unrelated to changing bundleID, i get this when upgrading to 0.40