docusaurus: Unable to change docs title

What is intended from PR #158 is that user can override Docusaurus provided strings that a project may not like (for example ReasonReact would like to say “Edit” instead of “Edit this Doc” in English). So they can modify i18en.json directly

Related code: https://github.com/facebook/Docusaurus/blob/fa20c93d5c1b5a9369cf1c5909955fc58f0dcb8e/lib/write-translations.js#L27-L31

https://github.com/facebook/Docusaurus/blob/fa20c93d5c1b5a9369cf1c5909955fc58f0dcb8e/lib/write-translations.js#L158-L164

But this introduces this bug because if I made a change to my title, old title from i18en.json exist & overrides i18en.json new title

If we always delete i18en.json that is just the same as not allowing to override strings and effectively deleting this code: https://github.com/facebook/Docusaurus/blob/fa20c93d5c1b5a9369cf1c5909955fc58f0dcb8e/lib/write-translations.js#L27-L31

That’s why there has been no issue with that code before #710 since October 2017

Sounds great @joelmarcey.

Are you going to work on it ? Otherwise, I can submit a PR when I’m back roughly after this week.

@endiliey

I think I kinda like option #2 after giving it some thought today. What we can do is load the generated i18n/en.json first and and get that in the currentTranslations array. Then load i18n/custom-en.json and either override current values in the array if there would be a duplicate or append to the array.

What do you think?

I have few alternatives

1. Don’t allow custom strings. This is like 1.1.5

Delete https://github.com/facebook/Docusaurus/blob/fa20c93d5c1b5a9369cf1c5909955fc58f0dcb8e/lib/write-translations.js#L27-L31

https://github.com/facebook/Docusaurus/blob/fa20c93d5c1b5a9369cf1c5909955fc58f0dcb8e/lib/write-translations.js#L158-L164

1. Allow custom string but maybe user has to explicitly name it custom-en.json

if (fs.existsSync(CWD + '/i18n/custom-en.json')) {
  currentTranslations = JSON.parse(
    fs.readFileSync(CWD + '/i18n/custom-en.json', 'utf8')
  );
}

If this is the case we might need to un- git ignore custom-en.json & update the docs