create-react-app: Package.json for eslint-config-react-app on NPM is incorrect

Describe the bug

The package.json file for eslint-config-react-app differs between NPM and Git for one peer dependency:

Git: "eslint-plugin-react-hooks": "1.x || 2.x || 3.x || 4.x"
Npm: "eslint-plugin-react-hooks": "1.x || 2.x"

Both has "version": "5.2.1", and everything else matches, except for this one peer dependency. 😕

Steps to reproduce

Inspect package.json on git:
✔ "version": "5.2.1"
✔ "eslint-plugin-react-hooks": "1.x || 2.x || 3.x || 4.x"
Run npm pack eslint-config-react-app
Inspect the package.json within the downloaded tgz package:
✔ "version": "5.2.1"
❌ "eslint-plugin-react-hooks": "1.x || 2.x"

Expected behavior

Would expect the acceptable versions of "eslint-plugin-react-hooks" to be the same in both places.

Actual behavior

Acceptable versions do not match. Means npm gives me a warning when I try to upgrade eslint-plugin-react-hooks to its latest version, 4.x:

> npm install eslint-plugin-react-hooks@4
npm WARN eslint-config-react-app@5.2.1 requires a peer of eslint-plugin-react-hooks@1.x || 2.x but none is installed. You must install peer dependencies yourself.

+ eslint-plugin-react-hooks@4.0.1
updated 1 package and audited 712 packages in 3.669s

About this issue

Original URL
State: closed
Created 4 years ago
Reactions: 16
Comments: 16 (1 by maintainers)

Commits related to this issue

Fix installation commands Ref: https://github.com/facebook/create-react-app/pull/9434#issuecomment-696566848 Ref: https://github.com/facebook/create-react-app/issues/8998 — committed to upleveled/eslint-config-upleveled by karlhorky 4 years ago

Most upvoted comments

Thank you, most gracious mr. Stale.

Svish on Aug 29, 2020

Still an issue. And seems to be “worse” too. The whole peerDependencies section seems to be incorrect.

From GitHub repo:

{
  "peerDependencies": {
    "@typescript-eslint/eslint-plugin": "^3.0.0",
    "@typescript-eslint/parser": "^3.0.0",
    "babel-eslint": "^10.0.0",
    "eslint": "^7.0.0",
    "eslint-plugin-flowtype": "^5.0.0",
    "eslint-plugin-import": "^2.21.1",
    "eslint-plugin-jsx-a11y": "^6.3.0",
    "eslint-plugin-react": "^7.20.0",
    "eslint-plugin-react-hooks": "^4.0.1"
  },
}

From NPM via npm pack eslint-config-react-app:

{
  "peerDependencies": {
    "@typescript-eslint/eslint-plugin": "2.x",
    "@typescript-eslint/parser": "2.x",
    "babel-eslint": "10.x",
    "eslint": "6.x",
    "eslint-plugin-flowtype": "3.x || 4.x",
    "eslint-plugin-import": "2.x",
    "eslint-plugin-jsx-a11y": "6.x",
    "eslint-plugin-react": "7.x",
    "eslint-plugin-react-hooks": "1.x || 2.x"
  },
}

Svish on Jul 14, 2020

Just noticed the package.json downloaded from Npm includes "gitHead": "d2f813f8897ffcd2f0b0d2da75d0c44924c92f4d", and checking the package.json for that, it is indeed different than master, yet both says they are "version": "5.2.1".

Confusing and annoying.

🤷‍♂️😕

Svish on May 13, 2020

Dear mr. Stale

This projects has not had any new releases since march, so this issue has not been fixed. Please do not close until it has been.

Humbly, Me

Svish on Aug 29, 2020

This is why my plugins are not getting loaded in my eslintrc. Still not stale.

quemazote on Sep 11, 2020

This is still an issue: npm WARN eslint-config-react-app@5.2.1 requires a peer of eslint-plugin-react-hooks@1.x || 2.x but none is installed. You must install peer dependencies yourself.

clarkdowding on Dec 20, 2020

This is still an issue for me too.

AdamFx990 on Sep 21, 2020