eza: Grid view is broken
Running
--gridwith the latest git version of zetta is broken on my machine.
E.g. by doing
cargo run --release -- --grid, or using an installed version (see screenshot below).
This is a fairly severe regression as the the default expected behavior of
exa/zettais to run--gridif nothing else is specified.
https://github.com/ogham/exa/pull/1165#issuecomment-1650420594
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Reactions: 1
- Comments: 30 (18 by maintainers)
Commits related to this issue
- fix: implement `EZA_GRID_ROWS` grid details view minimum rows threshold Grid details view had been prevented only by console width being unavailable. This changeset implements `EZA_GRID_ROWS` as sec... — committed to LeoniePhiline/eza by LeoniePhiline 2 years ago
- fix: implement `EZA_GRID_ROWS` grid details view minimum rows threshold Grid details view had been prevented only by console width being unavailable. This changeset implements `EZA_GRID_ROWS` as sec... — committed to LeoniePhiline/eza by LeoniePhiline 2 years ago
- fix: implement `EZA_GRID_ROWS` grid details view minimum rows threshold Grid details view had been prevented only by console width being unavailable. This changeset implements `EZA_GRID_ROWS` as sec... — committed to LeoniePhiline/eza by LeoniePhiline 2 years ago
- fix: implement `EZA_GRID_ROWS` grid details view minimum rows threshold Grid details view had been prevented only by console width being unavailable. This changeset implements `EZA_GRID_ROWS` as sec... — committed to LeoniePhiline/eza by LeoniePhiline 2 years ago
- fix: implement `EZA_GRID_ROWS` grid details view minimum rows threshold Grid details view had been prevented only by console width being unavailable. This changeset implements `EZA_GRID_ROWS` as sec... — committed to LeoniePhiline/eza by LeoniePhiline 2 years ago
- fix!: implement `EZA_GRID_ROWS` grid details view minimum rows threshold Grid details view had been prevented only by console width being unavailable. This changeset implements `EZA_GRID_ROWS` as se... — committed to LeoniePhiline/eza by LeoniePhiline 2 years ago
- fix!: implement `EZA_GRID_ROWS` grid details view minimum rows threshold Grid details view had been prevented only by console width being unavailable. This changeset implements `EZA_GRID_ROWS` as se... — committed to eza-community/eza by LeoniePhiline 2 years ago
- fix!: implement `EZA_GRID_ROWS` grid details view minimum rows threshold Grid details view had been prevented only by console width being unavailable. This changeset implements `EZA_GRID_ROWS` as se... — committed to erwinvaneijk/eza by LeoniePhiline 2 years ago
- fix!: implement `EZA_GRID_ROWS` grid details view minimum rows threshold Grid details view had been prevented only by console width being unavailable. This changeset implements `EZA_GRID_ROWS` as se... — committed to tertsdiepraam/eza by LeoniePhiline 2 years ago
After a bisect, I’ve arrive here:
af208285e8a0fb383f59372c966bdb77f94006e9
Gonna see if I can solve it.
What a problem with that rust programmers?.. Are they really capable of producing at least working as expected software?
I don’t bother myself spending time with so shitty language - such a waste of time!
And I provided an example of how it is not working - which puts us to condition where - no, they are not.
Yes, yes they are.
Look, you were even so nice and provided an example of a working rust project, as far as I can tell: https://github.com/eza-community/eza/issues/66#issuecomment-2198567463
@tribals has been blocked from all @eza-community projects for the time being, we do not tolerate that kind of behavior
In which case does terminal_size::terminal_size_using_fd return None? Could the terminal be incompatible?
row_threshold(the parsed value of EZA_GRID_ROWS) is only taken into account when a terminal column width could be determined or is set by the user. https://github.com/eza-community/eza/blob/c58ddcb7aa6b2cd0466869983cb701c45b5cbbc3/src/main.rs#L462If the terminal width is None, then EZA_GRID_ROWS has no effect. https://github.com/eza-community/eza/blob/main/src/main.rs#L471
Are any other eza or exa environment variables set in the terminal session? Which terminal is in use on which OS?
The only thing I can imagine from your example is that your terminal is wide enough that more rows could fit but only a maximum of 3 rows is rendered.
But that is only a suspicion. Can you elaborate what exactly is wrong (e.g. your terminal is wide enough, your terminal is smaller so too many rows are rendered, etc.)? Or do you have a screenshot of the output, which is kinda necessary to debug issues with the grid display.
Regarding https://github.com/uutils/uutils-term-grid/issues/6, do you think the behavior should change in uutils-term-grid? I don’t really care myself but I figured it could matter to some people here.
Agreed