expo: Expo 44 - Expo Print - HTML Page Height/Width no longer recognized.
Summary
I have an existing app that prints labels at a specific size 96px by 192px label/page size.
Print.printAsync({ html: myHTML, height: 92, width:192})
Since upgrading to Expo44 from Expo42
No matter how I send in the parameters the page size will always stay at the default size.
Managed or bare workflow? If you have ios/ or android/ directories in your project, the answer is bare!
managed
What platform(s) does this occur on?
iOS
SDK Version (managed workflow only)
44
Environment
expo-env-info 1.0.2 environment info: System: OS: Windows 10 10.0.22000 Binaries: Node: 16.11.1 - C:\Program Files\nodejs\node.EXE Yarn: 1.22.5 - C:\Program Files (x86)\Yarn\bin\yarn.CMD npm: 8.0.0 - C:\Program Files\nodejs\npm.CMD npmPackages: babel-preset-expo: 9.0.2 => 9.0.2 expo: ^44.0.0 => 44.0.6 react: 17.0.1 => 17.0.1 react-native: 0.64.3 => 0.64.3 Expo Workflow: managed
Reproducible demo
First is expo 44, second is expo 42 (desired size)
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Reactions: 1
- Comments: 40 (3 by maintainers)
Commits related to this issue
- [print] Fix page-breaks and margins not supported on iOS (#14802) The PDF snapshot renderer on iOS does not support page-breaks correctly and renders fonts with incorrect sizes. This is because it le... — committed to expo/expo by IjzerenHein 3 years ago
- [print][ios] fix width/ height not working on HTML print (#20046) # Why Fixes https://github.com/expo/expo/issues/16739, so now printing rendered HTML will change the page size when a custom `wid... — committed to expo/expo by keith-kurak 2 years ago
I am still having this issue and now 46 is released, I cannot upgrade from 42 since there is no work-around for this bug fix, and I cannot use the simulator (without upgrade to 46 for testing/development and downgrading to 42 for submission) and now i cannot use eas update since the version number is 42 which is below 45.
Is there any way we can get some attention to this? @byCedric @cruzach
Any update on this? I updated to Expo 45 and the issue still persists.
Since the update to Expo Go app requiring Expo 45, I can no longer use Expo 42 for development for this.
@borkanee @owenhope we just published this under the next tag so you can try it out, so you should be able to install it in your project via
npm install expo-print@next. Heads up that it will only work in a standalone app or development build, since it’s not yet updated in the Expo Go app.@borkanee I spoke to developer at expo and they’ve added to their sprint for expo 48, fingers crossed! Also they’re going to see if they can find the bug in the commit history and perhaps we can get them to write us a patch!
Finally !!!
I am very happy that the fix was approved and merged, I’m out of the project/company affected by this issue, but I still happy that this issue is fixed, thank you all and the thank you Expo team.
If I had to guess I think the issue was introduced in this commit https://github.com/expo/expo/commit/8a8ed4433790414a8b229064cd3a0795e3d428f4
@IjzerenHein do you maybe have any insight on this issue?
Please, this has been around since sdk 43