App: Workspace Role Admin is not translated it's hardcoded
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Note: User should have a workspace, if not create one using the following steps
- Click the FAB button
- Select New Workspaces to create a one.
Action Performed:
- Now, Go to Settings,
- Go to Preferences
- Select preferred language to
Espanol - Go back to settings
- Go to your workspace
- Select People
- Under Assignee user role
Adminis not Translated
Expected Result:
Role Admin should be translated.
Actual Result:
Actually, it’s not translated.
Workaround:
Can the user still use Expensify without this being fixed? Yes
Platform:
Where is this issue occurring?
- Web
- iOS
- Android
- Desktop App
- Mobile Web
Version Number: Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Expensify/Expensify Issue URL:
Proposal
Text Admin is hardcoded for the role here
https://github.com/Expensify/App/blob/8b10c1c1a0267eb66ef8fdc6e0049f9b101836a2/src/pages/workspace/WorkspacePeoplePage.js#L200-L202
Straight forward, we should just replace the text Admin with {this.props.translate('common.admin')}
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Comments: 26 (12 by maintainers)
@thienlnam @kevinksullivan Applied for the job on Upwork.
@thienlnam Will send a PR Shortly…
@Santhosh-Sellavel I’m still waiting to hear back on the last couple translations but will update you when I get them
‘Beneficial Owners’ =>
Beneficiario efectivo, ‘Additional Information’ =>Información adicional, ‘(check all that apply, otherwise leave blank)’ =>(marca todos los que apliquen, en caso de que ninguno aplique dejar en blanco), 'I own more than 25% of ’ =>Soy dueño de mas de 25% de, 'Somebody else owns more than 25% of ’ =>Otra persona es dueña de mas de 25% de, ‘Additional Beneficial Owner’, ‘Remove this beneficial owner’, 'Add another individual who owns more than 25% of ’ =>Agregar otra persona que es dueña de mas de 25% de, ‘Agreement:’ =>Acuerdo, ‘terms and conditions’ =>Términos y condiciones, ‘I certify that the information provided is true and accurate’ =>Certifico que la información dada es correcta,(Will update with missing ones soon)
@thienlnam We missed translations for the module in es.js. https://github.com/Expensify/App/blob/95bf36d950f57d01ae37af2e0d8f2e664a273b75/src/languages/es.js#L544-L556
I don’t know how to add screenshots for this, but if you share
estranslated copy I will update the file along with this PR. That should be enough! Thankscc: @iwiznia
I think this is fine to be its own issue, however if there was other missing translations, I would group those all together in the same issue.
cc @strepanier03