App: [Visual] Unexpected behaviour while editing messages with URLs in them

Paid with bonus for reporting. Apologies for the delay @aman-atg

I don’t think there are regressions on this one, and now that the n6-hold has been lifted we should pay @aman-atg ASAP. @mallenexpensify is out of office today but I’ll be sure to give him a bump tomorrow on this. Thanks so much for your patience @aman-atg. It’s highly unusual that a contributor would wait this long for payment.

I’m not entirely sure about this but I think the issue doesn’t get closed till the PR is deployed.

@Luke9389 can you work with @jasperhuangg if/when needed on this?

Can do! Welcome to the team Jasper!

Hired @aman-atg in Upwork. @Luke9389 can you work with @jasperhuangg if/when needed on this? He’s newer to E/App issues. Thanks

Job posted to Upwork, @aman-atg , let me know when you’ve submitted a proposal there. https://www.upwork.com/jobs/~01c72e946f00a7e2ff

Hey @aman-atg! Looks like a job was created for ya by @mallenexpensify. Feel free to request me for a review when you finish the PR!

Proposal

Explaination

• Here, we’re getting htmlForNewComment and while parsing we’re adding only target="_blank" attribute to our anchor elements <a> which makes it not equal to originalReportAction.message[0].html as the latter has rel="noreferrer noopener" as well as an attribute for anchor elements

https://github.com/Expensify/App/blob/30242db8c7703f8e430c641903baa5a1a2855151/src/libs/actions/Report.js#L1267

Solution

• We can fix this by adding rel="noreferrer noopener" after target="_blank" on this line https://github.com/Expensify/expensify-common/blob/7d8408c5c78792394eee8e079f115b1380221a23/lib/ExpensiMark.js#L117

Hey @aman-atg! I think this solution sounds great! Let me reach out to someone to get you moving with this, sorry for the delay.

Reproducable. Getting eng eyes on this to confirm we want to change/this will work and then we can go external