App: [Tracking] Single line Text is not clipping correctly
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Due to the recent upgrade to RN-web 0.17.5, we started to face a couple of issues where Text is not clipping correctly.
If you use <Text numberOfLines={1} />, it should be clipped with an ellipsis at the end. But this is not the case anymore. There is no fix effect rather multiple side-effects.
List of issues
- https://github.com/Expensify/App/pull/7097#pullrequestreview-847260602
- https://github.com/Expensify/App/issues/6913
- Typing indicator under the composer is clipped from half of the screen.
- Message me is clipped from half of the screen. https://expensify.slack.com/archives/C01GTK53T8Q/p1642409283049900
Platform:
Where is this issue occurring?
- Web
Solution
I have submitted a PR to fix this issue upstream https://github.com/necolas/react-native-web/pull/2193 which I am waiting to be merged.
So that we can upgrade our dependency.
Slack : https://expensify.slack.com/archives/C01GTK53T8Q/p1642087714433600
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Reactions: 2
- Comments: 24 (23 by maintainers)
YES! I’m not suggesting tracking issues aren’t good or helpful, I am a BIG fan. Let’s just keep payments dedicated to the non-tracking issues that the tracking issues links too.
Yeah, usually they are created as normal issues. I created this tracking issue as I saw there were many issues that started to pop up due to the same cause. So I thought to track them all together.
But I found the solution along the way so I just referenced this to clearly state that the fix solves all the issues and we have a track of it.
Yeah, I liked the template suggestion.
Paid since this is a unique issue and I don’t want to forget. cc @Beamanator , let’s all think of how to best manage fixes in external libs. I guess we just need one issue like this that has all the details and for the proper labels to be added so that CM and likely CME (so they can help determine price/complexity?) have 👀 on the fix and so the CM can pay.