App: [Regression test steps needed] [$1000] Request/Send money available in default-rooms/chatrooms with 2 members, error if used.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- FAB -> Create workspace.
- Settings -> Workspaces -> Manage members. Ensure it has exactly two members.
- Open #admin or #announce room, click + and notice that Request/Send money options are available.
- Select
Request money-> Enter any amount -> Select Next -> Select Request
Expected Result:
Request/Send money options should not be available in default rooms.
Actual Result:
Request/Send money options are available, using them results in error.
Workaround:
unknown
Platform:
Where is this issue occurring?
- Web
- iOS
- Android
- Desktop App
- Mobile Web
Version Number: Reproducible in staging?: Reproducible in production?: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Expensify/Expensify Issue URL: Issue reported by: @Ollyws
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1669560477526229
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0188ec5bdeb4f1e5b7
- Upwork Job ID: 1597173028123549696
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 41 (28 by maintainers)
In a default room or user created policy room it does not make sense to show the send/request money options as those can only happen in a DM or policy expense chat (though the policy expense chats are still behind a beta IIRC so not sure it’s really relevant to this conversation).
It seems like we still want to allow splitting a bill (though less sure how valuable that is cc @trjExpensify) - kind of a tangent though.
I think for this issue the main thing is that we shouldn’t be seeing the request/send options in default rooms with 2 members and the solution is to wrap the place where we push those options in with a check to
ReportUtils.isChatRoom().@Ollyws first solution is in the right spot - but not sure if they realized how it would affect the bill split feature (which again, isn’t entirely clear that we would necessarily want that behavior).
unassigning me as @thesahindia was assigned for PR review!
Yeah, it has come up a few times. Like here, and we don’t need to restrict people from using
Split billin rooms.Wrt to showing
Spilt billin a room with only 2 members. I think that’s fine and better than the added complexity of switchingRequest moneyforSplit billas the room member list grows, given that it’s an edge case that you would create a room and only add one other person in the first place.@s77rt According to the thread linked here: https://github.com/Expensify/App/issues/13069#issuecomment-1328316315 request/send money shouldn’t be available in chatrooms atall, only add attachment and split bill should be shown. ‘2 members’ was only mentioned because that’s when the request/send money options were shown.