App: [PAID] [$1000] Bug: Link with multiline text loses markdown when edited
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Note: Originally identified in this expensify-common PR review comment. The solution will be within that repository.
Action Performed:
- Login with any account and go to any chat room
- Send this message:
[multiline
text](https://google.com/)
- Edit this message
Expected Result:
In the edit input field, the original message should be autofilled
[multiline
text](https://google.com/)
Actual Result:
In the edit input field only the link text is shown without the original markdown
multiline
text
Workaround:
Don’t edit the message or re-write the link.
Platforms:
All platforms
Version Number: v1.2.49.0 Reproducible in staging?: Yes Reproducible in production?: Yes Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:
Expensify/Expensify Issue URL: Issue reported by: @aimane-chnaif Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1673025066209189
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01f4669fd1f66776d8
- Upwork Job ID: 1612959960562159616
- Last Price Increase: 2023-01-10
About this issue
- Original URL
- State: closed
- Created a year ago
- Comments: 53 (37 by maintainers)
@tienifr PR tested and approved. @Luke9389 All yours.
Adding my 2 cents here:
\s\Sis better approach./gisis not safe for browser compatibilityAnd it would be good to add automated tests instead of not needing screenshots in expensify-common repo
That should enough for the expensify-common package, though I’ll recommend checking previous PRs.
We’ll need another PR with the merged SHA commit and here we’ll fill the whole checklist with platform screenshots.
Quick question though I thought we’re going to implement the
\s\Sregex instead of appendinggis?I am going to change it to weekly so that I’m still checking in on it but we don’t have to worry about daily updates for the sake of updates.
Waiting for reg test on this issue. I notice that one is monthly, should we change the urgency of this one to match so that it’s not going Overdue every day?
Bumped the reg test request.
@strepanier03 I meant to close contract between you and me. Not job post.
Paid out Aimane as well.
Only step is to have the new RG added and once it is I’ll close this GH as completed.
Thank you @aimane-chnaif, @mananjadhav, @tienifr, and @Luke9389 for the communication and urgency fixing this, well done team!
Thanks @strepanier03. Appreciate the prompt action on this.
@mananjadhav - Accepted proposal and sent offer.
@tienifr - Accepted proposal and sent offer.
Latest update: 🚀 Deployed to staging by @Luke9389 in version: 1.2.55-0 🚀
@strepanier03 I’ve applied too for C+ review. Thanks.
@tienifr the expensify-common PR is merged. Can you create a PR for the App.
Yeah I think using
[\s\S]would be better as we’re already using similar pattern for HTML to markdown, bold, etc.@tienifr You can create the PR with this proposal
cc - @Luke9389