App: [On Hold] Improve error message when a debit card is added
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Break down in numbered steps
- In NewDot sign in with an expensifail account
- Click on the Avatar icon (Settings) -> Payments -> Add Payment method -> Debit card
- Fill in the form and for the card number enter a valid non-debit testing card like
4111111111111111
Expected Result:
A descriptive error message should be shown.
Actual Result:
The error Auth CreateFund returned an error is shown. eg: conor@expensifail.com, getting these logs with the error showing as 400 Invalid debit card
Workaround:
We could look up the logs for the user to find the error message and communicate that to the customer to solve
Platform:
Where is this issue occurring?
- Web
- iOS
- Android
- Desktop App
- Mobile Web
Version Number: Reproducible in staging?: Reproducible in production?: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Expensify/Expensify Issue URL: Issue reported by: Slack conversation:
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 83 (68 by maintainers)
@isabelastisser Nothing needed her for now, assigning you in case there’s any follow-up questions from @marcochavez for anything else
I’m re-assigning to another BugZero team member in case there are any further steps, as I’m going on sabbatical in 30 minutes!
We’re depending on a new sandbox token but we’re focused on waves
Still waiting for the new token
I’m back! Thanks, @sophiepintoraetz !
Created a PR to change the message, but the Bancorp sandbox token is expired again (so the change can’t be tested on staging). We’d need to put this issue on hold until the token is updated.
Removing the hold title since the debit test cards are not working on staging. I will work on this one in spare cycles
Still waiting on Bancorp’s response. I’m going to use this issue to post updates about it.
Not overdue, changing this to weekly.
Triggered auto assignment to @isabelastisser (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.Cool, then
Make sure you've entered a valid debit card.will be the final copy, thanks!Additionally, I’m going to put this one on hold until we are able to communicate with Bancorp sandbox API to use test debit cards on staging/production, otherwise, Applause won’t be able to test the fix when the PR is deployed.
Ah ok, got it, so there’s two possibilities:
Seems to address 1 fine, but it’s a little subtle on 2. @rosegrech what do you think on
It’s a very slight rewording, but should emphasise that it has to be valid, and a debit card
We only allow debit cards for this flow, and there’s a possibility that the user could enter a credit or pre-paid card.
sure thing, this is a bit smoother:
Hah, @marcochavezf has confirmed that he is working on a PR for the issue. Marco, can you link the draft PR to this issue?