App: mWeb - New Room- Button ''New room'' is not floating
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue was found when executing #6880
Action Performed:
- Go to https://staging.new.expensify.com
- Log in with expensifail account.
- Click the FAB button again and select
New room. - Click on Room name
Expected Result:
The button should be floating
Actual Result:
Button New room is not floating
Workaround:
Unknown
Platform:
Where is this issue occurring?
- Mobile Web / Safari browser
- IOS (Native)
Version Number: v1.1.24-0
Reproducible in staging?: Yes
Reproducible in production?: New feature
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Issue was found when executing #6880
Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Comments: 42 (34 by maintainers)
Removed this as a “deploy blocker” because the solvable part of this issue has been solved by @parasharrajat . The remaining issue in Safari + mobile is not fixable according to @parasharrajat (see here)
Added ‘External’ label to get someone who can answer @parasharrajat here.
Adding external label to get help from the people that handle that kind of thing 😃
Thanks @parasharrajat , that solved the issue 🎉
yeah, this is not a regression but this could be considered as part of that PR as you were fixing the overlapping behavior of the button. Anyways, I have created the PR.
Ok. It seems it does not work on IOS. so @thesahindia You would have to create a follow-up PR to fix this as this is supposed to work on all platforms as part of https://github.com/Expensify/App/pull/6880.
I’m going to reassign to @aldo-expensify since he seems to know more and he can make the call on whether or not we close this since it seems not fixable. In the meantime, maybe we can remove the blocker ?
@aldo-expensify this is Mobile Web / Safari browser
Sadly, we can’t fix this issue. Safari Mobile Web does not work well with flexbox so we can just close this issue. You can observe the same behavior for ProfilePage and other pages where the button is fixed at the bottom.