App: [MEDIUM] Admin “force submit” throws a RBR red dot in the LHN and double messaging

Slack conversation: https://expensify.slack.com/archives/C02MW39LT9N/p1703190155736439?thread_ts=1703187017.215259&cid=C02MW39LT9N

Action Performed:

Pre-testing requirement: Collect workspace type with the isPolicyExpenseChatEnabled NVP set (SO).

  1. As the admin, go to OldDot and change the scheduled submit frequency to manually for a workspace
  2. Log back into NewDot as the member (or refresh if you already are in another window) • Verify that the LHN row for the workspace chat includes a GBR green dot for the draft report awaiting submission ✅
  3. Tap the workspace chat row to navigate to the workspace chat view • Verify that the draft report preview component appears in the workspace chat ✅ • Verify that the draft report preview component in the chat:
  4. Includes a green Submit button ✅
  5. Sign-in as the collect policy admin account, and navigate to the member’s workspace chat in NewDot
  6. Tap the report preview component of the draft report to navigate to the expense report view
  7. Tap the Submit button ❌ • Verify the text in the next steps banner updates to reflect the report has been submitted and is awaiting approval: “Waiting for %approverName% to review these requests” ✅ • Verify a system message is added to the expense report from the admin that reads: “submitted %reportTotal%” ✅ • Verify a green Approve/Pay button appears to approve the report ✅

Expected Result:

If an admin “force submits” an expense there’s a GBR and one message about the expense submitted

Actual Result:

If an admin “force submits” an expense there’s a RBR and multiple messages about the expense submitted

Screenshots/Videos

image

View all open jobs on GitHub

About this issue

  • Original URL
  • State: closed
  • Created 6 months ago
  • Comments: 37 (26 by maintainers)

Most upvoted comments

@rlinoz I believe @JmillsExpensify had this issue today.

is your testing account also an admin? The problem happens when the approver is not an admin since we did not support this case in OldDot and currently the submit report command does not allow this for a mere approver.

We were discussing it a bit here

@mananjadhav, @blimpich, @greg-schroeder Whoops! This issue is 2 days overdue. Let’s get this updated quick!

Waiting to hear back on this slack thread before turning PR from draft to regular PR

Picking this up. Will start work on it tomorrow.