App: Investigate the cause of the Performance Regression for 'Open Search Page TTI'
Recently, we’ve seen a slew of Performance Regressions getting red-flagged for the ‘Open Search Page TTI’ flow.
We first saw the uptick in time occur somewhere around the merging of these PRs:
- Keyboard is visible for a brief moment on request/send money page after getting back from currency search page #15205 🟢 - no regression
- Fix miss-matched SMS email suffix on sign in page #15351 🟡 - some regression
- replace onModalHide with onDismiss for the web #15298 🔴 - DeployBlocker triggering regression.
We tried reverting Fix miss-matched SMS email suffix on sign in page #15351 (PR) to no avail. And we DID revert replace onModalHide with onDismiss for the web #15298. Again no help.
So now we’re very confused about where this regression is coming from. @roryabraham has graciously created the ability to run the E2E tests on a specific branch a la carte. So we’re going to try and use that to simulate git bisect essentially to figure out the offending PR / commit.
In the meantime we’ve decided to not block the deploy on this. However, to close this issue we should be getting the Open Search Page TTI back to around ~600ms. Currently it’s regressed to ~660-700ms
About this issue
- Original URL
- State: closed
- Created a year ago
- Comments: 32 (24 by maintainers)
@hannojg just reopened the issue and assigned it to you