App: Inconsistent Android back button behavior while navigated to a modal view
If you haven’t already, check out our contributing guidelines for onboarding!
Expected Result:
The Android hardware back button should work when pressed.
Actual Result:
When you open the settings page the first back button press is ignored (as if an extra invisible page was added to the page stack), but the second and third back button press work as expected.
Action Performed:
- Open the settings modal
- Press the back button
Platform:
Android
Notes/Photos/Videos:
- This issue is caused by a bug in
react-navigationand must be fixed in that repo first. - See: https://github.com/react-navigation/react-navigation/issues/9364
- Workarounds will not be accepted.
Expensify/Expensify Issue URL: https://github.com/Expensify/Expensify/issues/157248 Upwork link: https://www.upwork.com/jobs/~016d2a711284ef2fc7
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Comments: 56 (55 by maintainers)
@parasharrajat seems like an npm cli version issue. Some reference issues https://github.com/npm/cli/issues/2000 and https://github.com/npm/cli/issues/2119.
@parasharrajat yes force upgrading this dependancy is a way of doing this. But in this case we will have to perform a full testing cycle on this app to be sure about all the issues which we might face.
I think this full testing is not in the scope of this issue. So I will try to force upgrade the dependancy and share my results which are related to this issue.
@ahmedahtazaz Have you tried the
--forceswitch command? I think the above comment is saying to list down the issues that you face after installing it forcefully with old react-native.Sorry everyone. So this is an interesting development, but I think this change here will actually make the proposal no longer necessary.
https://github.com/react-navigation/react-navigation/commit/5ae0badc44b576d464f8841822a911b18a698403
Maybe we should hold until it’s published?
@ahmedahtazaz Doesn’t react-navigation gives that by default?