App: [HOLD on App/issues/4733 & facebook/react-native/pull/37397] [$4000] Inline code blocks do not appear on Android Native

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Navigate to a chat
  2. Send a word surrounded by `

Expected Result:

The sent message is an inline code block

Actual Result:

The text surrounded by ` is invisible

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.0 Reproducible in staging?: Reproducible in production?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/43996225/231933562-2b88c197-6d19-4089-8a73-c9d33d87531e.mp4

https://user-images.githubusercontent.com/43996225/231933582-15b51768-85b8-43fe-9c42-05c8a4b35f67.mp4

Expensify/Expensify Issue URL: Issue reported by: @alex-mechler Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681421292014409

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011f07d26570e8df08
  • Upwork Job ID: 1648098209202724864
  • Last Price Increase: 2023-05-02

About this issue

  • Original URL
  • State: closed
  • Created a year ago
  • Comments: 83 (30 by maintainers)

Most upvoted comments

Apologies but I am finally going on Parental Leave. I am reassigning to another member of the team.

Can you share those issues here? It will be helpful. You can join our Slack channel. Hope over to the contributing guidelines which will tell you about everything.

The original reason to have this WrapperText implementation on Native to support padding, border radius and border to the text while keeping the flow inline.

@anashakim any more thoughts on this at all?

Im into something just need to test it again and will write a new proposal

@akinwale I have written the same proposal if you read the conversation we are looking for the source of the problem as this was working before it stopped

What’s the issue, when it happens, did you manually change the code to create the issue or it happens in the staging build itself?

yes I manually changed the code and wrapped the Text with a View then the text disappeared and got the some problem.

As I know a few weeks or months earlier this was working fine. Any recent changes may have caused this regression so we need to find where it broke and handle it.

Ok I will look into that

Might be helpful!

This issue is originating here: https://github.com/rawalyogendra/App/blob/6a1ae162886703a772d27081eff4c99a49dbf971/src/components/InlineCodeBlock/WrappedText.js#L45-L74

When I tried to render only the first level of array without nested rendering it worked.

I’m heading on sabbatical, so also need to reassign!