App: [HOLD on #34528][$500] mWeb - Amount only is seen on header in IOU details page if navigated through deep link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.24-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

  1. Create a new account, lets call it Account A
  2. Create another new account, account B
  3. Send an IOU from account A to account B and go to IOU details page and copy the URL
  4. Sign in with account B
  5. Navigate to the copied URL on step 3
  6. Observe the IOU header in the IOU details page

Expected Result:

There should be “From … <link to parent chat>” under the header

Actual Result:

  1. Only the amount is visible
  2. Getting Not Found View
  3. After reload, the [Deleted message] title can be briefly seen
  4. Money request info is missing and had to reload another time to get the correct view

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/93399543/04e7985b-6dba-4d38-b7c5-a7e8cecec01f

https://github.com/Expensify/App/assets/16493223/db09a1a1-3bd6-456b-a5f3-976c4856b47a

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013f1ca3c28189a2c4
  • Upwork Job ID: 1745430304265371648
  • Last Price Increase: 2024-01-18
  • Automatic offers:
    • s77rt | Reviewer | 0
    • shahinyan11 | Contributor | 0

About this issue

  • Original URL
  • State: open
  • Created 6 months ago
  • Comments: 100 (72 by maintainers)

Most upvoted comments

As per the slack discussion we will be going with a frontend solution which is to call OpenReport if we are viewing a report and we don’t have its parent report in Onyx, OpenReport(report.parentReportID)

@lschurr We should still hold on https://github.com/Expensify/App/issues/34528 as it’s blocking testing/evaluating the proposed solutions correctly

@rlinoz I am ready to continue work on this issue

@rlinoz @s77rt If you decide to open a new issue as a result, would you mind mentioning my proposal in it as the first proposal ? Because I investigated the root cause and proposed a solution already

@jeremy-croff

I posted mine to specifically propose the usage of fetchReportIfNeeded selector, as his diddn’t have this implementation

It was referenced here https://github.com/Expensify/App/issues/34346#issuecomment-1937096697

As well as include important details about how the logic is ordered, correct usage of onyx, and memoization

I don’t think that’s a critical factor for proposal selection

Still discussing on slack

image didn’t fix it