App: [Hold for payment Aug 3] KeyboadShortcut is broken
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Open Search with
Cmd + K - Open New Group with
Cmd + Shift + K - Click outside New Group popup to close it.
- Press
Escapeto close Search.
Expected Result:
Escape should close the Search page.
Actual Result:
Escape doesn’t close the Search page.
Workaround:
The user can click outside Search page/ click on the close button.
Platform:
Where is this issue occurring?
Web ✔️ iOS Android Desktop App ✔️ Mobile Web
Version Number: Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Upwork job: https://www.upwork.com/jobs/~011663eb89a2b43197
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Comments: 19 (15 by maintainers)
@tgolen, @puneetlath, @rushatgabhane Eep! 4 days overdue now. Issues have feelings too…
OK, thanks! That should do the trick. 🟢 to work on this.
Posted to Upwork, assigning an engineer to review. https://www.upwork.com/jobs/~011663eb89a2b43197
Added
Dailylabel so @puneetlath will see it for triage. @parasharrajat , can you elaborate what needs further planning? I saw @rushatgabhane 's Slack post but there are no comments there. We can followup in a comment there and ‘share with room’ to try to get more eyes on, if needed