App: [Hold for Payment 30-11-22][$500] Close account - Refactor to use Form component

Sorry the automation not working meant I missed this yesterday. Paid 👍

Sounds good, I’ll make sure the final payment issued is $500, pls ignore the current price in Upwork

Great clarification. We should add this to the OP somewhere for clarity.

@mvtglobally it’s a little confusing, but the issue is no longer what the original report was 😅 I believe @Beamanator has updated the issue report now to reflect this.

@laurenreidexpensify, we are already working on the PR here 😄 It took some time because we were deciding how we want to handle the error.

Updated OP & title to reflect new goal for this issue & PR

I also just tested and it’s fixed now. Disregard above, thanks!

I just tested and it’s fixed now but since we are refactoring this page to use Form, let’s change the description and test that everything works correctly after the refactor.

I don’t agree with that ^^^. I’m still able to reproduce this issue.

@Puneet-here I believe we do still show that modal, if there is an error when trying to close the user’s account

Also needed help, I couldn’t find where we are setting success message at closeAccount onyx key.

Currently we’re setting success when the account gets closed, we’re sending that via Pusher from the back-end which is why you can’t see it, sorry 🤷

Oh sorry I should have clarified, I am on the Marketing team too, so just did the waiting for copy chore as part of the overall review here, so I think we good to go 👍

I agree with @Beamanator’s point though happy to wait and see where we align internally first.

Same, 1 message sounds good to me too.

I also vote to use 1 message

I like having one message.

Please enter your default contact method to close your account.

It strikes me as weird that we refer to it as contact method instead of email, but I guess that’s to account for mobile sign in?

Groovy thanks @shawnborton

@thesahindia are you good to move forward and evaluate proposals?

I like the idea of always being able to click the button & show an error if it’s not right, so the user knows exactly what to type to close the account.

I agree with that @Beamanator

Those all look good to me, I think we should get @Expensify/design 's opinion on the first point:

• Currently the “Close Account” page’s ‘Close account’ button is disabled until the user types in their exact default contact method. Should we keep it this way or should we make it always enabled, and just show an error if the contact method they enter isn’t exactly like their default contact method?

I like the idea of always being able to click the button & show an error if it’s not right, so the user knows exactly what to type to close the account.

Additionally, maybe we can update the text on that page - “Type your phone number or email address to confirm.” doesn’t seem super helpful since they don’t have to type “either one”, they have to type “exactly whatever their default contact method is”

Sorry, I couldn’t look into it. I will test it tomorrow.

Cool thanks @luacmartins

@thesahindia Let’s move forward knowing that it would be great to refactor that page to use Form, as long as it will work 😄 (I’d recommend asking for some evidence that it works fine)

That page is not tracked yet. Feel free to add it to the Form tracking issue!