App: [hold for payment 25 august] Onyx changes break Exisiting App architecture.

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

cc: @marcaaron @kidroca

ISSUE

There few parts that will stop working due to the recent changes to Onyx. We have to either plan for migration or fix Onyx so that those continue working.

There is a component Enablepayment which uses the following implementation.

1. It disregards the stored values in Onyx for userWallet. https://github.com/Expensify/App/blob/50828ab6752324988fbfdc7020878c80adf174bd/src/pages/EnablePayments/index.js#L50-L58.
2. We start with a userWallet:{} value.
3. After the component is mounted we make an API call to get the new data.
4. But If the data coming from the backend is the same as the stored value in Onyx, there will not be any rerendered.
5. Due to this, we will never be able to show the real data on the screen.
6. There will be many instances of this approach in the App and multiple times data will not change but we still want to make a request to check for updated value and show it to the user.

Slack thread => https://expensify.slack.com/archives/C01GTK53T8Q/p1628106963153400

Expected Result:

UI should be updated to show the recent state of data.

Actual Result:

1. No change in the UI state.

Workaround:

None. It breaks the App.

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.0.82 Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Expensify/Expensify Issue URL:

View all open jobs on Upwork