App: [HOLD for payment 2024-05-06] [HOLD #36071] [$1000] Textinput is not focused in chat after visiting conceirge help
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Create a new workspace
- Go to the workspace invite page
- Click
?and then Get Assistance - Click chat with concierge
- See that the textinput isn’t focused (you have to manually click into it to begin typing)
Expected Result:
Text input should be focused
Actual Result:
Text input is not focused (Also navigate other chats and their text input is not focused)
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.3.31-2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Text input is not focused after visiting coneirge help.webm
https://github.com/Expensify/App/assets/43996225/aa6f2326-5a98-4155-8187-8bc869d791a9
Expensify/Expensify Issue URL: Issue reported by: @Habtamu-Asefa Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686984617296819
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01f42405b3f19296c4
- Upwork Job ID: 1674465220531503104
- Last Price Increase: 2023-07-06
- Automatic offers:
- fedirjh | Reviewer | 0
- bernhardoj | Contributor | 0
About this issue
- Original URL
- State: open
- Created a year ago
- Comments: 77 (48 by maintainers)
@Skalakid that works. I can do it after @fedirjh approves and I get assigned to this issue 👍
@bernhardoj thanks for reporting the issue, I investigate it and come back to you with more details
Hmm after bumping the
react-native-live-markdownversion the issue is reproducible again. To fix it we should apply @bernhardoj’s proposal changes. Maybe let’s bump the version of the package to0.1.63and add proposed changes in @bernhardoj’s PR? What do you think about it?If you log the auto-focus value here, https://github.com/Expensify/App/blob/faff990f6ce64fbef53712169b23788e3fd59ad0/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx#L278-L279
the value will be
falsebecause themodal.isVisiblevalue is stuck at true.I found out that after we use live markdown (RNMarkdownTextInput) on the web, setting the autofocus prop to false doesn’t work. It always auto-focus the input and looks like that happens because we are setting the selection here. https://github.com/Expensify/react-native-live-markdown/blob/7c9d9b050874b8b2a0ef8d000304b428dc8ec0e8/src/MarkdownTextInput.web.tsx#L527-L533
Commenting the effect solves the auto-focus issue.
cc: @Skalakid @BartoszGrajdek I guess
Do you mean going back won’t go back to the get assistance page? If yes, then that’s the expected behavior. We want to close the RHP. You can test it with other RHP flows such as request money (for reference).
Yes, the testing step is a bit outdated. You can find the Get Assistance in workspace invite page.