App: [hold for payment 2024-04-29] [$500] Live markdown for money request description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1711641837108169
Action Performed:
- Press on the global create button
- Press
Request Money->Manual-> enter any amount -> choose any participants - Press on the description field
- type markdown text into the description field
Note: There are more permutations of this, the intention with this issue is that it should capture all money request description fields, including:
- 1:1 requests, splits, and send money
- different types of requests such as manual v.s. scan v.s. distance
Expected Result:
The markdown styling should render in real-time, as it does for the main chat composer.
Actual Result:
No live markdown formatting.
Workaround:
n/a
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0147562f8d45f3f241
- Upwork Job ID: 1773388950435934208
- Last Price Increase: 2024-04-11
- Automatic offers:
- alitoshmatov | Reviewer | 0
- ShridharGoel | Contributor | 0
About this issue
- Original URL
- State: open
- Created 3 months ago
- Comments: 46 (37 by maintainers)
No, we should not. We should ship these PRs separately because, even though the implementation is similar, all the testing and QA can be separate. This issue requires thorough testing of all money request flows already, which is a pretty heavy testing burden. We don’t need to pile that on top of an existing PR.
Neither proposal is particularly detailed. I think the changes are simple, but what I’d like to see more details on is the testing and rollout plan that we would use to implement them
Still pending @ShridharGoel accepting upwork offer
https://github.com/Expensify/App/pull/39519 is merged so we should feel free to proceed with the PR now
Since we already have a PR to establish the pattern here, and that’s recognized in @ShridharGoel’s proposal, I’m not too concerned about diverging implementations.
Going to assign this to @ShridharGoel - and I recommend that you wait for https://github.com/Expensify/App/pull/39519 to be merged to open your PR.