App: [HOLD for payment 2024-04-25] [$500] `MISSING_TRANSLATION` is shown in pronoun field even without any pronouns set

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: Reproducible in staging?: needs reproduction Reproducible in production?: needs reproduction If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): @quinthar Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @quinthar Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1711338168652399

Action Performed:

  1. Login to an account in which no pronouns set
  2. Open the profile page

Expected Result:

Pronoun field is empty

Actual Result:

Appears as ``Missing Translation" Also there are console logs

[alrt] pronouns.He/him was not found in the en locale - {“stack”:“"Error\n at a.alert (https://staging.new.expensify.com/vendors-406b3bb5f059dfb66309.bundle.js:1:3900169)\n at Module.B (https://staging.new.expensify.com/main-93cf1b44624c1fe66191.bundle.js:1:2335910)\n at https://staging.new.expensify.com/main-93cf1b44624c1fe66191.bundle.js:1:1771873\\n at R (https://staging.new.expensify.com/main-93cf1b44624c1fe66191.bundle.js:1:3953628)\n at Co (https://staging.new.expensify.com/vendors-406b3bb5f059dfb66309.bundle.js:1:5860880)\n at Ms (https://staging.new.expensify.com/vendors-406b3bb5f059dfb66309.bundle.js:1:5881792)\n at vl (https://staging.new.expensify.com/vendors-406b3bb5f059dfb66309.bundle.js:1:5918898)\n at bc (https://staging.new.expensify.com/vendors-406b3bb5f059dfb66309.bundle.js:1:5907143)\n at gc (https://staging.new.expensify.com/vendors-406b3bb5f059dfb66309.bundle.js:1:5907071)\n at mc (https://staging.new.expensify.com/vendors-406b3bb5f059dfb66309.bundle.js:1:5906934)"”}

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

image (23)

image (24)

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019e0d665061e60d96
  • Upwork Job ID: 1774914293176807424
  • Last Price Increase: 2024-04-01
  • Automatic offers:
    • ntdiary | Reviewer | 0
    • gijoe0295 | Contributor | 0
Issue OwnerCurrent Issue Owner: @johncschuster

About this issue

  • Original URL
  • State: closed
  • Created 3 months ago
  • Comments: 18 (6 by maintainers)

Most upvoted comments

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@ntdiary] The PR that introduced the bug has been identified. Link to the PR: #12301
  • [@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/12301/files#r1581826250
  • [@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No need
  • [@ntdiary] Determine if we should create a regression test for this bug. No need
  • [@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. No need
  • [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

After this migration, this issue should not reappear if the list of pronouns remains unchanged in the future, so I don’t feel strongly about creating a regression test. Do you have different thoughts? 😃

If the list is subject to change in the future, we should also pay attention to maintaining them simultaneously.

Payment has been issued. @ntdiary, can you please complete the BZ list above?

Issue not reproducible during KI retests. (Second week)

I like going with solution 2, and I would like to recommend to use an Onyx migration instead of using the profile page to correct the pronouns.