App: [HOLD for payment 2024-04-25] [$250] Remove IOUCurrencySelection.js and copy any changes since Nov 27 into IOURequestStepCurrency.js
This is a part of https://github.com/Expensify/App/issues/29107. You can look at that issue for more context behind the cleanup process.
Problem
The app has two redundant components:
Old Component: IOUCurrencySelection
New Component IOURequestStepCurrency
Solution
Following the examples (example 1, example 2), the Old Component needs to be completely removed from the codebase
- Look at the history of the Old Component
- If there are any changes since Nov 27, 2023 which have not been added to the New Component, copy those changes
- Replace all uses of the Old Component with the New Component
- Remove all traces of Old Component
- Be sure to update all routes and navigation to use the new
:actionparam (instead of being hard-coded with"create") - Update any logic like
isEditingto use the new action param from the route
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0107fbe87259b2ef2c
- Upwork Job ID: 1747632778655997952
- Last Price Increase: 2024-01-24
- Automatic offers:
- akinwale | Reviewer | 28119949
- ZhenjaHorbach | Contributor | 28119950
Issue Owner
Current Issue Owner: @saklugerAbout this issue
- Original URL
- State: closed
- Created 5 months ago
- Comments: 31 (17 by maintainers)
@ZhenjaHorbach @akinwale No longer hold, let’s process the next step
We should get a full proposal to ensure that all the paths are covered properly. The initial instructions give a brief overview, but the code should really be inspected to clearly understand all the necessary changes.
On Fri, Jan 19, 2024 at 1:41 PM Sasha Kluger @.***> wrote:
$250 to @akinwale and to @ZhenjaHorbach