App: [HOLD for payment 2024-04-25] [$250] Remove IOUCurrencySelection.js and copy any changes since Nov 27 into IOURequestStepCurrency.js

This is a part of https://github.com/Expensify/App/issues/29107. You can look at that issue for more context behind the cleanup process.

Problem

The app has two redundant components:

Old Component: IOUCurrencySelection New Component IOURequestStepCurrency

Solution

Following the examples (example 1, example 2), the Old Component needs to be completely removed from the codebase

  1. Look at the history of the Old Component
  2. If there are any changes since Nov 27, 2023 which have not been added to the New Component, copy those changes
  3. Replace all uses of the Old Component with the New Component
  4. Remove all traces of Old Component
  5. Be sure to update all routes and navigation to use the new :action param (instead of being hard-coded with "create")
  6. Update any logic like isEditing to use the new action param from the route
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0107fbe87259b2ef2c
  • Upwork Job ID: 1747632778655997952
  • Last Price Increase: 2024-01-24
  • Automatic offers:
    • akinwale | Reviewer | 28119949
    • ZhenjaHorbach | Contributor | 28119950
Issue OwnerCurrent Issue Owner: @sakluger

About this issue

  • Original URL
  • State: closed
  • Created 5 months ago
  • Comments: 31 (17 by maintainers)

Most upvoted comments

@ZhenjaHorbach @akinwale No longer hold, let’s process the next step

We should get a full proposal to ensure that all the paths are covered properly. The initial instructions give a brief overview, but the code should really be inspected to clearly understand all the necessary changes.

On Fri, Jan 19, 2024 at 1:41 PM Sasha Kluger @.***> wrote:

@mountiny https://github.com/mountiny are we treating this like a TS Migration issue? I.e. do we require proposals or just a volunteer?

— Reply to this email directly, view it on GitHub https://github.com/Expensify/App/issues/34607#issuecomment-1901084140, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJMAB4DFTAX3HVHSY7UAATYPLK73AVCNFSM6AAAAABB5OFKMOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBRGA4DIMJUGA . You are receiving this because you authored the thread.Message ID: @.***>