App: [HOLD for payment 2024-04-09] [$500] Mark down - Live preview for code block with strikethrough is incorrect

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.45-1 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

Launch New Expensify app
Go to any chat
Type ~Code~
Note that live mark down preview
Send the text

Expected Result:

The live mark down preview for ~Code~ should correctly show the actual mark down

Actual Result:

The live mark down preview for ~Code~ is incorrect. It shows that the strikethrough is applied, when strikethrough does not work with code block in the sent text

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/dd57a2e1-3d63-4a0a-b56a-b6e08b4be49b

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~012e80f0cbfad42ad6
Upwork Job ID: 1763259471765831680
Last Price Increase: 2024-02-29

About this issue

Original URL
State: closed
Created 4 months ago
Comments: 31 (19 by maintainers)

Most upvoted comments

@brandonhenry live markdown is only on mobile right now, FYI. I’m able to reproduce it there.

puneetlath on Feb 29, 2024

Thanks @shubham1206agra. I see that https://github.com/Expensify/App/pull/38152 bumps react-native-live-markdown to a higher version which includes our fix too. Let’s hold for that instead.

@puneetlath @allroundexperts

bernhardoj on Mar 26, 2024

Copying the comment from the PR to here for visibility.

Is the next step to open an App PR to apply this expensify-common update?

@puneetlath @allroundexperts we would need to update the expensify-common version in react-native-live-markdown, but I think it would make sense to have the same version of expensify-common in App too.

react-native-live-markdown already has the latest version of expensify-common (dc8ea98), except our recently merged commit (9e47e1f). I think we need a help from SWM team to update the package as react-native-live-markdown latest version is 0.1.28 and if we update it, that would be 0.1.29 which is 24 patch version apart from the current version in the App (0.1.5).

I see that this issue will update the react-native-live-markdown to the latest version, but I don’t see the App PR yet (@robertKozik cmiiw). I think we can hold for that issue or ask them to include our expensify-common update to react-native-live-markdown.

bernhardoj on Mar 20, 2024

Thanks for the proposal @brandonhenry. I think you missed to include italics / links in your proposal which in my opinion should be removed as well. Also, I think for consistency, we should follow the pattern already established in the h1 parsing.

As such, I think @bernhardoj’s proposal looks better to me.

🎀 👀 🎀 C+ reviewed

allroundexperts on Mar 6, 2024