App: [HOLD for payment 2024-03-22] [$500] [MEDIUM] Approved expense preview does not show GBR when submitter needs to add a bank account
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: Reproducible in staging?: needs reproduction Reproducible in production?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @anmurali Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1704819780539799
Action Performed:
Create a money request and submit it to a Collect workspace. Approve and pay as the workspace admin.
Expected Result:
After an expense is approved, the submitting user should see a GBR in the expense preview which prompts them to add a bank account by clicking in to reveal the Add bank account CTA.
Actual Result:
After an expense is approved, the submitting does not see a GBR in the expense preview, and there is no indicator that they must click in to find the Add bank account CTA.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01e7910dca0f3c5b57
- Upwork Job ID: 1747385136600576000
- Last Price Increase: 2024-01-23
- Automatic offers:
- cubuspl42 | Reviewer | 28131009
- tienifr | Contributor | 28131010
About this issue
- Original URL
- State: closed
- Created 6 months ago
- Comments: 41 (24 by maintainers)
@happy-man
Welcome to Expensify! Please ensure to read the contributing guidelines and check out a few other issues with other contributors’ proposals to get a feeling of how the Expensify process works. If you have any general questions unrelated to this issue, ask them on
#expensify-open-sourceSlack channel.Yeah, sorry for the delay! Some things apparently changed under our feet because of the work from other PRs; we want to ensure everything is working as expected.
PR is being actively reviewed.
As per the PR status, the most important feedback was this thread. I bumped @tienifr.
Thanks @stephanieelliott !
@cubuspl42 Proposal updated to reflect the scope in the OP
@stephanieelliott no, I was just confused if the GBR, CTA are in the scope of the issue. As long as it’s confirmed that we would like to include those behaviors here, it’s ok 👍
@happy-man
Hi again!
Please ensure to read the contributing guidelines. Have you read the contributing guidelines? If you have some questions, you can also check the contributing guidelines. Sometimes, I feel that people don’t read the contributing guidelines, but then I realize that it’s unlikely, because two bots and four people ask them to read the contributing guidelines.