App: [HOLD for payment 2024-03-13] MEDIUM: [$500] Drop domain names when searching for users and auto-filling mentions
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v1.4.35-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): N/A Logs: N/A Expensify/Expensify Issue URL: N/A Issue reported by: N/A Slack conversation: N/A
Action Performed:
- Create a room with 4 members: 2 on the same private domain, 1 on another private domain, and 1 on a public domain
- Draft a message that includes mentions for each user.
Expected Result:
When mentioning a user on the same private domain, the search result for the mention should not include the domain for the user’s email. For example, given a message between two users - nikkiwines@expensify.com and puneet@expensify.com - the search and auto-complete behavior should look like this:
When mentioning a user on a public domain or on a different private domain, the behavior should remain largely as it is, though we will now prepend an @ to the front of the login details (e.g. Nikki Wines nikkiwines@expensifail.com becomes Nikki Wines @nikkiwines@expensifail.com) when showing the mention options in search.
Actual Result:
The search result and mention auto-complete a same-private-domain mention contains the full email domain, even though the domain name gets removed after sending the message.
https://github.com/Expensify/App/assets/16747822/860a332c-b2e2-44dc-ad00-8f5f8fc409bf
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01c84c193620b0a5db
- Upwork Job ID: 1754684823991881728
- Last Price Increase: 2024-02-06
- Automatic offers:
- tienifr | Contributor | 0
About this issue
- Original URL
- State: closed
- Created 5 months ago
- Comments: 56 (40 by maintainers)
I don’t feel super strongly. Given the name in bold won’t have a @ sign I err on the side of not highlighting it. If we highlighted the
@symbol we’d end up with different highlights.I hope that made sense, but yeah, I’m mostly on not highlighting it. Keen on @dannymcclain and @shawnborton thoughts too though
Please don’t lie @MelvinBot. Are you having memory issues? 💀
Ah got it. Thank you so much for clarifying, I missed that part of the doc and was kind of just cargo cult’ing other proposals that I saw.
Ok, after reviewing, this wouldn’t be a reporting bonus but the amount wouldn’t be the full payment amount for a PR. I’m suggesting to go with 25% of the PR amount and apply that as a payment for the extra update. In this case, it would be 500 for the PR and then 125 for the additional PR update.
Technically the phone number logins are emails (in that they all use
@expensify.sms) and would fall under the same category 😅 but I understand your meaning and it definitely wasn’t clear in the issue description. Additionally, since updating the phone number logins required separate logic from the email ones, I think an argument can be made for applying a bonus here. What do you think @alexpensify?That makes sense. Thanks for the detailed explanation. @tienifr’s proposal should work well!
🎀 👀 🎀 C+ reviewed
@allroundexperts Yes the part where we search the mention will work.
But after we select a mention (
@puneet), then try to send it, as per the requirement it will only be a text likehey there, @puneetbeing sent in the Composer. Currently our app cannot process such a email-stripped text into the correctmention-userhtml tag, it needs the full email (likehey there, @puneet@expensify.com).The
ExpensiMarkchange I suggested is so that it can handle email-stripped mention (like@puneet)@allroundexperts - will any of these proposals help here? Thanks!
Yup, what Jon said! I agree with that.
I think that screenshot looks good! We can get some design team feedback too if you’d like.