App: [HOLD for payment 2024-03-13] [$500] [Nav][Simplified Collect][Workflows] Delayed Submission/Monthly Frequency - Fix redirection screen on reload
Context
- Create a Collect policy in NewDot
- Go to Workspace’s settings > Workflows
- Toggle the
Delayed Submissionand click onMonthly - A RHP should open, refresh the page
Expected result You should be redirected back to the workflows screen
Actual Result You are redirected to the #admins room
See video: https://github.com/Expensify/App/assets/29673073/46449156-88c9-476b-b962-2bd73ede5a26
Task Your goal is to fix the navigation issue.
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0122ad7d632e92e433
- Upwork Job ID: 1763223792123248640
- Last Price Increase: 2024-02-29
- Automatic offers:
- situchan | Reviewer | 0
- ikevin127 | Contributor | 0
About this issue
- Original URL
- State: closed
- Created 4 months ago
- Comments: 38 (20 by maintainers)
That’s not really an effort if you just copied someone solution. I wouldn’t say the RCA is clear as it’s just a reverse from the solution. RCA: we don’t map here Solution: we map here without even explaining why we should do the mapping and why the report screen is shown.
I must admit it’s my fault to not do it earlier as I never expected someone would take the chance to convert my comment into a proposal.
There’s no offending PR. This is follow-up of new feature and original PR author/reviewer was already aware of this during PR review. I think this is still WIP and full regression test will be added after simplified collect / workflows is completely done. That being said, we can close this.
Contributor: @ikevin127 paid $500 via Upwork Contributor+: @situchan paid $500 via Upwork.
@situchan can you complete the BZ checklist above plz? Thx
I think we should hold this until https://github.com/Expensify/App/pull/37213 is merged as not testable yet. @bernhardoj please submit formal proposal including the case of Categories page (https://github.com/Expensify/App/issues/37505 was closed as same root cause)