App: [HOLD for payment 2024-02-26] [$250] Remove MoneyRequestMerchantPage.js and copy any changes since Nov 27 into IOURequestStepMerchant.js
This is a part of https://github.com/Expensify/App/issues/29107. You can look at that issue for more context behind the cleanup process.
Problem
The app has two redundant components:
Old Component: MoneyRequestMerchantPage
New Component IOURequestStepMerchant
Solution
Following the examples (example 1, example 2), the Old Component needs to be completely removed from the codebase
- Look at the history of the Old Component
- If there are any changes since Nov 27, 2023 which have not been added to the New Component, copy those changes
- Replace all uses of the Old Component with the New Component
- Remove all traces of Old Component
- Be sure to update all routes and navigation to use the new
:actionparam (instead of being hard-coded with"create") - Update any logic like
isEditingto use the new action param from the route
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~013e56ba72ea82ea62
- Upwork Job ID: 1747386410233479168
- Last Price Increase: 2024-01-24
- Automatic offers:
- hoangzinh | Reviewer | 28132635
- DylanDylann | Contributor | 28132636
About this issue
- Original URL
- State: closed
- Created 5 months ago
- Comments: 49 (32 by maintainers)
Oh hmmm, maybe we need to wait for the prod deploy so the payment automation kicks in, I’ll reopen
Sounds good! All set to issue payment on the 26th then.
@neonbhai @DylanDylann @brunovjk Thanks for your proposal, everyone. @DylanDylann’s proposal looks good to me. He is first and mentions all the requirements here
Link to proposal https://github.com/Expensify/App/issues/34611#issuecomment-1894915141
🎀👀🎀 C+ reviewed
@hoangzinh Updated proposal to cover edit split flow as discuss here
Done!