App: [HOLD for payment 2024-02-15] [HOLD for payment 2024-02-14] [$500] [Wave8] [Ideal Nav] Hide `Subscriptions` menu item on iOS and Android native

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.36-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @AndrewGable Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1707240281243759

Action Performed:

  1. Go to new.expensify.com on iOS/Android native
  2. Click the wrench tab
  3. Observe the Subscriptions menu item in the LHN

Expected Result:

Due to restrictions with the App store, we should hide this menu item on iOS and Android native devices.

Actual Result:

We don’t hide it, and that puts us at risk of being pulled from the app store.

Workaround:

Yes, they can go to mWeb or to web/desktop to see the subscription menu item.

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native (incl. iPadOS)
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

IMG_5651

View all open jobs on GitHub

CC: @mountiny @hayata-suenaga

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e6bee6862397d920
  • Upwork Job ID: 1754927211226951680
  • Last Price Increase: 2024-02-06
  • Automatic offers:
    • aimane-chnaif | Reviewer | 28146833
    • codinggeek2023 | Contributor | 28146834

About this issue

  • Original URL
  • State: closed
  • Created 5 months ago
  • Comments: 33 (21 by maintainers)

Most upvoted comments

Paid! Summary as follows:

Alright, going to pay this one out. No regression, something we missed in implementation design.

Seems like @sofi-a is off for the day. Let’s assign @codinggeek2023 Please create platform files in /libs similar to willBlurTextInputOnTapOutside 🎀 👀 🎀 C+ reviewed

10 min more. The next candidate is @codinggeek2023 since they proposed first