App: [HOLD for payment 2024-02-14] [$250] Remove MoneyRequestTagPage.js and copy any changes since Nov 27 into IOURequestStepTags.js
This is a part of https://github.com/Expensify/App/issues/29107. You can look at that issue for more context behind the cleanup process.
Problem
The app has two redundant components:
Old Component: MoneyRequestTagPage
New Component IOURequestStepTags
Solution
Following the examples (example 1, example 2), the Old Component needs to be completely removed from the codebase
- Look at the history of the Old Component
- If there are any changes since Nov 27, 2023 which have not been added to the New Component, copy those changes
- Replace all uses of the Old Component with the New Component
- Remove all traces of Old Component
- Be sure to update all routes and navigation to use the new
:actionparam (instead of being hard-coded with"create") - Update any logic like
isEditingto use the new action param from the route
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01f0c8228cceba8683
- Upwork Job ID: 1747632892276064256
- Last Price Increase: 2024-01-17
- Automatic offers:
- fedirjh | Reviewer | 28119689
- dukenv0307 | Contributor | 28119690
About this issue
- Original URL
- State: closed
- Created 5 months ago
- Comments: 26 (14 by maintainers)
I don’t think the BZ checklist applies here since this was more a feature update and not really a bug (please check me on that @fedirjh!)
Proposal Updated
Added a note about why should we not include the action param.