App: [HOLD for payment 2024-02-01] [$500] HIGH: Enable threading on all system messages

Problem: Our chat-centric design is to allow you to chat on basically anything. However, right now you can’t thread up a response to a system message, for no clear reason. One specific place this is a limitation is when there is a system message in the #admins room – such as when someone adds an outsider to a room. By not allowing threading, we disrupt the most natural place to discuss this with the employee.

Solution: Enable threading on all system messages from a user, exactly as if they had manually posted that same message as a comment. This means:

  • Name the thread based on the parent comment that is being threaded
  • Invite the author of the parent comment (in this case, the system message) to the thread even if they don’t have access to the parent room. (This can happen because users can cause system messages to posted “from” them to rooms they aren’t in).

So far as I know this should be doable entirely on the client side without any back-end work. However, if you determine that’s not true (and if you need some back end help) please just let us know.

Test: Verify:

  1. Alice creates a workspace Alice's Apples
  2. Alice invites Bob to the workspace
  3. Bob creates a room #bagel-lovers that Alice is not in
  4. Bob invites Cathy (who is not a member of the workspace) to #bagel-lovers
    • This cause Bob to post a system message to the #admins room of Alice's Apples saying: Bob invited Cathy to #bagel-lovers
  5. Alice opens a thread on that system message
  6. Alice posts “What up Bob, why did you invite Cathy?” in that thread
  7. Confirm Bob is invited to that thread and sees Alice’s message
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0143d329144a3feb35
  • Upwork Job ID: 1740548696855482368
  • Last Price Increase: 2024-01-05
  • Automatic offers:
    • aimane-chnaif | Reviewer | 28088772

About this issue

  • Original URL
  • State: closed
  • Created 6 months ago
  • Comments: 38 (14 by maintainers)

Most upvoted comments

This is not bug but feature.

Regression Test Proposal

  1. Alice creates a workspace Alice’s Apples
  2. Alice invites Bob to the workspace
  3. Bob creates a room #bagel-lovers that Alice is not in
  4. Bob invites Cathy (who is not a member of the workspace) to #bagel-lovers
  5. This cause Bob to post a system message to the #admins room of Alice’s Apples saying: Bob invited Cathy to #bagel-lovers
  6. Alice opens a thread on that system message
  7. Alice posts “What up Bob, why did you invite Cathy?” in that thread
  8. Confirm Bob is invited to that thread and sees Alice’s message
  9. Mention by @ should be available
  10. Click into the room header and go to Members
  11. Confirm that it shows the member list with options to add/remove

@quinthar after Aimane reviews the PR it passes on to the Contributor Manager Engineer (who is me in this case) for final review. Aimane finished their review in the wee hours of the morning PST time, so it sat there for 12 hours because I didn’t get to it till this morning. Here is my review. I left some comments, so we are now waiting for those to be addressed, and then we can merge.

review completed with some NAB comments

started review. will complete today

Thanks Nicolay! I’m going to assign you to the issue so that we can keep track who’s working on this and to keep melvin-bot happy

Hi, I’m Nicolay from Callstack - expert contributor group - and I will try to help here.