App: [HOLD for payment 2024-01-31] [$500] New organic sign-up dropped in an “Hmm.. it’s not there” chat
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: Reproducible in staging?: needs reproduction Reproducible in production?: needs reproduction If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @trjExpensify Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1703070069444339
Action Performed:
- Go to staging.new.expensify.com
- Sign-up with a private domain email address not on the
defaultRoombeta > get the magic code from email - Enter the magic code > land in NewDot
Expected Result:
An organic sign-up should land in the Concierge chat on first sign-in with the global create FAB expanded
Actual Result:
- Concierge chat not highlighted in the LHN, and the main pane is a “Hmm… it’s not there” chat screen (which we reasonable believe to be the default domain room as noted here).
- Clicking on the Concierge chat row, the reportID in the URL updates to the Concierge chat reportID and the main pane updates: https://staging.new.expensify.com/r/8392311097742670
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01b5beb5290c8be9e8
- Upwork Job ID: 1743242903474585600
- Last Price Increase: 2024-01-05
- Automatic offers:
- rojiphil | Contributor | 28106268
About this issue
- Original URL
- State: closed
- Created 6 months ago
- Comments: 49 (27 by maintainers)
$500 approved for @mananjadhav based on summary above.
Issue not reproducible during KI retests. (Second week)
@rojiphil Got it, that makes sense. I think your proposal should work then!
I checked @rojiphil’s proposal and it seems to fix the issue. My concern is whether or not to fix it from BE as this code hasn’t been updated. But if we plan to fix it from FE then @rojiphil’s proposal is fine.
🎀 👀 🎀 C+ reviewed.
After doing some more testing in the thread, I think for some reason we’re trying to send a new private domain email sign-up into the default domain room on first sign-in. As my private domain doesn’t have access to the
defaultRoomsbeta which is what is hiding that unreleased room from the masses, I’m hitting the “Hmm… it’s not there!” screen as I’m dropped into that chat.As you can see from this video from @m-natarajan attempting a reproduction on
@applause.expensifail.comdomain which has access to all betas, they get dropped into the domain default room.https://github.com/Expensify/App/assets/16232057/6fc359cb-7a9e-49d7-8aba-99f2b38116c1
So the investigation is to figure out when and why that started to happen. The fix is to stop doing that and land a new private domain organic sign-up in the Concierge DM, like we do a public domain sign-up.
CC: @jasperhuangg for visibility as someone with experience with rooms.