App: [HOLD for payment 2024-01-04] [$500] [Wave 6: Workspace Chats] IOU-The request created is not displayed in the manual expense created page.

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.10 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause-Internal Team Slack conversation: @

Action Performed:

Launch app
Tap employee Workspace chat
Tap on a exsisting manual expense which is created and submitted.( if not create a manual expense and submit it)
Tap plus icon near compose
Tap request money
Enter amount
Tap next
Tap request

Expected Result:

On paid policy, if the expense report is not in open state, do not show the Request Money option in the menu on the expense report. Only in case the expense report is open.

This is only the case for paid policies

Actual Result:

The request created is not displayed in the manual expense created page.Request created is shown only in Worspace chat page.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

Screenshots/Videos

https://github.com/Expensify/App/assets/115492554/f6227074-d6a6-4fb0-aca7-f8f1c7a8d8b9

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~010ae27c329f45f3a6
Upwork Job ID: 1734161470412218368
Last Price Increase: 2023-12-11
Automatic offers:

hoangzinh | Reviewer | 28062552
bernhardoj | Contributor | 28062553

Issue Owner

Current Issue Owner: @stephanieelliott

About this issue

Original URL
State: closed
Created 7 months ago
Comments: 35 (26 by maintainers)

Most upvoted comments

Regression Test Proposal

Sign in to an Expensify account that has a paid WS chat
Go to that paid WS chat
Request money in USD currency
Press the request preview to open the IOU report
Press the add action (+) button
Verify there is a Request money option
Submit the request
Press the add action (+) button again
Verify there is no Request money option

Do we agree 👍 or 👎

hoangzinh on Dec 29, 2023

@bernhardoj ah you’re right, updated.

bernhardoj on Dec 18, 2023

Ah, I see. Do you mean we can just do it like this?

// this will only return true on a paid policy expense report, right?
if (isDraftExpenseReport(report)) {
    return true;
}

bernhardoj on Dec 15, 2023

If the expense report is not a draft report. so the stateNum and statusNum are not 0.

Free policies, cannot have open reports so there we have logic that if the expense report is padi, you cannot request more money there

mountiny on Dec 14, 2023