App: [HOLD for payment 2023-12-29] [$250] Migrate SearchPage.js to function component
Class Component Migration
Filenames
Task
- We currently have some class components in our codebase that we would like to refactor to a function component.
- Here’s a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
- If you need additional guidance, please ask in #expensify-open-source
- Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~015fa113b288776a75
- Upwork Job ID: 1681356452396900352
- Last Price Increase: 2023-07-18
About this issue
- Original URL
- State: closed
- Created a year ago
- Comments: 71 (39 by maintainers)
@isabelastisser I don’t think that we have checklists for component migrations.
@isabelastisser The update is that @koko57 has taken over the PR and has resolved my pending comments. I’ll take a look at it again tomorrow.
Yep. On my list for tomorrow!
Just wanted to close the loop on ^, we reverted the migration PR in https://github.com/Expensify/App/pull/27476
Oh but we are also in a “merge freeze” that the moment. So, even if the PR is ready I think we are not going to merge it yet 😬
Thanks, I’ll check it out. Looks like it is has been ready for a review for some time. Usually people tag me on the reviews when things are ready 🙃.
I also see that @allroundexperts is doing the review so they should be assigned here?
✅ Contributor details stored successfully. Thank you for contributing to Expensify!
@marcaaron’s what’s the situation here? Do we need to remove
help wanted?