App: [HOLD for payment 2023-12-18] [$500] RBR polish on failed split receipt scans

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.3.84-4 Reproducible in staging?: Yes Reproducible in production?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @trjExpensify Slack conversation: (internal ref) https://expensify.slack.com/archives/C02NZ2HGJAZ/p1697493830052679?thread_ts=1697488517.137999&cid=C02NZ2HGJAZ

Action Performed:

  1. Global create > Request money > scan a picture of your receipt or a image file that will fail
  2. Select 2 participants to split > confirm
  3. Wait for receipt scanning to fail
  4. ~Observe the split preview component in the groupDM contains a red dot that’s left-aligned~ being fixed here
  5. Observe the groupDM chat in the LHN does not have a red dot on the chat row
  6. Observe we’re showing Split $0.00 in the LHN preview message instead of Receipt missing details when a split scan fails

Expected Result:

~The red dot for the “RBR” (red-brick-road) in a preview component should be right-aligned~ being fixed here. The chat row in the LHN should have a RBR red dot The LHN preview message shows Receipt missing details not Split $0.00 when a split scan fails

Actual Result:

The red dot on the preview component is left-aligned and the chat row does not have a red dot

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround? N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari image
MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01fdff9c9cc073642c
  • Upwork Job ID: 1714068202452070400
  • Last Price Increase: 2023-11-09
  • Automatic offers:
    • Ollyws | Reviewer | 27613990
    • dukenv0307 | Contributor | 27613993

About this issue

  • Original URL
  • State: closed
  • Created 8 months ago
  • Comments: 48 (26 by maintainers)

Most upvoted comments

I don’t think a regression test is really helpful here as it takes a long time to test for (while waiting for the recepit scan to fail) and doesn’t affect the flow in any significant way.

That isn’t a good reason in itself, really. A customer has the same experience and we need to make sure it works for them! We have failed scan receipt regression tests, so all good.

As for the payments then, confirming as follows?

Let me know and I’ll settle up tomorrow!