App: [HOLD for payment 2023-11-30] Chat not loading after redirection from OldDot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.0-3 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): N/A Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Slack conversation:

Context

We’re testing a feature to redirect users that sign up on Expensify Classic (OldDot) to New Expensify. Sometimes, upon being redirected to NewDot, the app doesn’t fully load, and the chat view shows the loading animation.

Action Performed:

  1. Open staging.expensify.com
  2. Click on “Email” > enter any email address from a public domain that +classicredirect (that’s what enables the redirection for now, while we test). For example: your.name+classiredirect123@gmail.com > click Next > Join
  3. At that point you’ll be redirected to NewDot, and the app should load on the Concierge chat. Sometimes, the Concierge chat doesn’t get displayed

The issue doesn’t always happen (maybe 1 in 10 times in my personal experience), so you might have to test multiple times in a row with different accounts.

Expected Result:

The Concierge chat should be displayed.

Actual Result:

The Concierge chat is not displayed, there’s a loading animation in the chat view instead.

Workaround:

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

https://github.com/Expensify/App/assets/2229301/6b258ef2-d860-4b15-891b-66b87386b5b3

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @kevinksullivan

About this issue

  • Original URL
  • State: closed
  • Created 7 months ago
  • Comments: 24 (14 by maintainers)

Most upvoted comments

Quick and dirty fix: https://github.com/Expensify/App/pull/31522

However, I think that some work to clean up and simplify this flow would be valuable. We can have only one transition page that works if a user is:

  1. Already signed in
  2. Signed in to the wrong account
  3. Provided an exitTo, or not
  4. etc…

and then we could create E2E tests for all those flows. I noticed a number of redundancies and seemingly unnecessary complexities while looking through this code.

I can help with this issue 🙂