App: [HOLD for payment 2023-11-29] [$500] Inconsistency bug - Assign Task - Task description does not remove empty quotes (works fine in private notes)

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app
  2. Open task report or assign any user task and open the report
  3. Open description
  4. Enter text with multiple empty quotes eg:
> Hello
>
>
  1. Save the description and observe that description displays only one quote with text on task page (which is correct)
  2. Again open description and observe that extra greater then signs are not removed
  3. Paste similar text in composer, send and edit and observe that extra greater then signs are removed
  4. Similarly try the text in private notes of any user and observe that private notes too removes the extra signs

Expected Result:

App should remove greater then signs with no text after it when description is saved like we do throughout the app

Actual Result:

App does remove greater then signs with no text after it when description is saved in task

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: v1.3.74-2

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/93399543/e73faad0-7050-47c0-afe2-6c111401c4b3

https://github.com/Expensify/App/assets/93399543/1e91fe16-3689-451b-86cf-4d3076294b02

https://github.com/Expensify/App/assets/93399543/2c3bc4a6-d324-4faf-acd0-496025996ce1

https://github.com/Expensify/App/assets/115492554/e4746bb4-5982-493c-ae8b-8d2ff5248307

https://github.com/Expensify/App/assets/115492554/055e5086-998b-42b7-883b-579e0cbd5a9b

https://github.com/Expensify/App/assets/115492554/c9a8b7d8-49dd-42dc-8ba0-b1cb402f0626

Expensify/Expensify Issue URL:

Issue reported by: @dhanashree-sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695746974925629

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01cbe475b72eea075d
  • Upwork Job ID: 1707098020774612992
  • Last Price Increase: 2023-09-27
  • Automatic offers:
    • DylanDylann | Contributor | 27099861
    • dhanashree-sawant | Reporter | 27099863

About this issue

  • Original URL
  • State: closed
  • Created 9 months ago
  • Comments: 71 (55 by maintainers)

Most upvoted comments

@garrettmknight Currently, these are a few components that will remove all the redundant “>”:

  1. Message composer
  2. Private notes
  • Message composer is the component that is most used in our app so I think we should follow it

No. We still need the FE change because as I mentioned in my proposal

Currently, with the description field, we are saving the input text directly

Got it - feel free to propose the other bug in #expensify-bugs for Applause to vet - let’s stick to the focus of this bug here.

Interesting - so Android isn’t handling markdown. Is that a different way to describe the issue?

I’d agree that this is a clear inconsistency in how the two text areas work and without any reasoning for one to work differently (i.e. why is the text area in a task not removing erroneous pieces when the text composer?). It’s a question of standardizing where the behavior should be the same, not whether the app is broken outright.