App: [HOLD for payment 2023-11-21] [DISTANCE] [$500] LOW: BUG: individuals can be selected for distance requests

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v1.3.89-6 Reproducible in staging?: yes Reproducible in production?: yes If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @Ashim Sharma Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693731984757459

Action Performed:

go to fab button -> request money -> distance
Select valid addresses in start and finish points
click next
Now type in and select a user’s mail address . eg user1@gmail.com

Expected Result:

Individuals should not appear as participant options for distance requests

Actual Result:

Individuals do appear as participant options for distance requests. After selecting one the confirmation page shows the amount as $0.

Workaround:

You will get an error after requesting and can make a request to a workspace instead.

Platforms:

Which of our officially supported platforms is this issue occurring on? All

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

https://expensify.enterprise.slack.com/files/U04H96S40LC/F05RFFKS9T2/screen_recording_2023-09-03_at_2.45.37_pm.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01c5428782ec334786
Upwork Job ID: 1716560993895415808
Last Price Increase: 2023-10-23
Automatic offers:

cubuspl42 | Reviewer | 27491620
neonbhai | Contributor | 27491621

About this issue

Original URL
State: closed
Created 8 months ago
Comments: 39 (24 by maintainers)

Most upvoted comments

Payment Summary:

Issue Reporter: $50 @ashim Sharma - paid in Upwork Contributor: $500 @neonbhai - paid in Upwork Contributor+: $500 @cubuspl42 - paid in Upwork

laurenreidexpensify on Nov 22, 2023

Payment due tomorrow

laurenreidexpensify on Nov 20, 2023

The PR that introduced the bug has been identified. Link to the PR:
- N/A (this was more of a “UX bug”; we needed to adjust the app’s behavior until #23291 is live)
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- No need for additional discussion
Determine if we should create a regression test for this bug.
- No need for a regression test (this functionality will soon change as part of #23291)
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- N/A

cubuspl42 on Nov 15, 2023

Raising PR shortly!

neonbhai on Nov 6, 2023

okay although there is a previous, duplicate issue exists, let’s handle this here.

Assigning @neonbhai

hayata-suenaga on Nov 2, 2023

The point of this issue is to fix the current problem on the frontend, which is that individuals can be selected for distance requests. After P2P distance requests are enabled in #23291 it will be possible, but that’s a ways out, so we should fix it in th meantime.

neil-marcellini on Nov 1, 2023

hi @cubuspl42 could you take a peek at the proposals to see if any will work?

Christinadobrzyn on Oct 24, 2023