App: [HOLD for payment 2023-11-06] [$500] Chat - Email pattern is not recognized when sending a comment
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Go to any report
- Type in compose box
codeemail@gmail.com (without any space) - Notice the email is not recognized as email link
Expected Result:
Email pattern should be recognized and become blue link style
Actual Result:
Email pattern is not recognized
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.3.75-11
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/9f1a9c5c-acf9-4398-8a19-72cd86aee73e
https://github.com/Expensify/App/assets/78819774/f693a44b-fd37-4281-8b6e-3333b32b8d35
https://github.com/Expensify/App/assets/78819774/de6fb8f5-4983-48ac-bc77-d770af31da37
https://github.com/Expensify/App/assets/78819774/aa02e491-4f6d-4ecb-a3fd-2a985d478863
https://github.com/Expensify/App/assets/78819774/c34c5f06-0117-4204-9344-6542c7cd79f1
https://github.com/Expensify/App/assets/78819774/39722c47-7b2f-44da-a90f-173908b4f565
https://github.com/Expensify/App/assets/78819774/bf194de5-2451-455d-9ce1-4d091a14870c
Expensify/Expensify Issue URL:
Issue reported by: @tsa321
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696219306455269
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0181685d1a16ff4d31
- Upwork Job ID: 1708873970110574592
- Last Price Increase: 2023-10-16
- Automatic offers:
- eh2077 | Contributor | 27335685
- tsa321 | Reporter | 27335687
About this issue
- Original URL
- State: closed
- Created 9 months ago
- Comments: 46 (29 by maintainers)
Thank you for the updated detailed proposal @eh2077. Breaking down the regex really helped and I like the solution a lot. Hired.
@Christinadobrzyn As I wrote in my previous comment:
Proposal
Updated alternative solution to simplify the regex with more detail explanation and examples.
cc @burczu @neil-marcellini
I agree with the C+ that @akamefi202’s proposal looks good. Are there any other tags that we should also consider which might come before an email?
@eh2077 your proposal is very good as well, but I don’t quite follow every piece of your explanation. It’s a complex regex and I like that you want to simplify it, but it also comes with more risk, I think. Would you please edit your explanation in an attempt to make it even more clear? Also if you could show some unit test examples that would really help.
What do you think @burczu? I’m holding off on assignment because I like the idea of simplifying the regex.
I’ve just reviewed all the proposals and the one from @akamefi202 works best for me and I personally like it the most, so I would proceed with it.
The proposal from @ZhenjaHorbach does not work for me and the one from @eh2077 works but it leaves an angle bracket at the end (please see the image below):
🎀 👀 🎀 C+ reviewed
@Christinadobrzyn Sure thing! I’ll take a look at this issue soon.
Hi @burczu - I reassigned this because @jjcoffee isn’t feeling well and I don’t want to stress him with work. Can you review the proposals and let us know if any will work?
Aw, I’m sorry @jjcoffee - I’ll reassign this so you don’t have to stress and can focus on getting better. I hope you feel better soon!
@Christinadobrzyn Sorry I’m ill at the moment, hope to get better soon, but feel free to reassign if it’s urgent enough!
@Christinadobrzyn Sorry I haven’t had a chance to test the updated proposal properly yet. I will add it to my list for Monday!